1 Return-Path: <cworth@cworth.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 74A9A4196F5
\r
6 for <notmuch@notmuchmail.org>; Fri, 23 Apr 2010 12:15:40 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.89 tagged_above=-999 required=5
\r
12 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, T_MIME_NO_TEXT=0.01]
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id AmxBHtfnQN+O; Fri, 23 Apr 2010 12:15:39 -0700 (PDT)
\r
17 Received: from yoom.home.cworth.org (localhost [127.0.0.1])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 667F5431FC1;
\r
19 Fri, 23 Apr 2010 12:15:39 -0700 (PDT)
\r
20 Received: by yoom.home.cworth.org (Postfix, from userid 1000)
\r
21 id 31BED568DE4; Fri, 23 Apr 2010 11:47:04 -0700 (PDT)
\r
22 From: Carl Worth <cworth@cworth.org>
\r
23 To: Dirk Hohndel <hohndel@infradead.org>, notmuch@notmuchmail.org
\r
24 Subject: Re: improve from-header guessing
\r
25 In-Reply-To: <1271451102-11336-1-git-send-email-hohndel@infradead.org>
\r
26 References: <1271451102-11336-1-git-send-email-hohndel@infradead.org>
\r
27 Date: Fri, 23 Apr 2010 11:47:04 -0700
\r
28 Message-ID: <87pr1qf1lj.fsf@yoom.home.cworth.org>
\r
30 Content-Type: multipart/signed; boundary="=-=-=";
\r
31 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
32 X-BeenThere: notmuch@notmuchmail.org
\r
33 X-Mailman-Version: 2.1.13
\r
35 List-Id: "Use and development of the notmuch mail system."
\r
36 <notmuch.notmuchmail.org>
\r
37 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
38 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
39 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
40 List-Post: <mailto:notmuch@notmuchmail.org>
\r
41 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
42 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
43 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
44 X-List-Received-Date: Fri, 23 Apr 2010 19:15:40 -0000
\r
47 Content-Transfer-Encoding: quoted-printable
\r
49 On Fri, 16 Apr 2010 13:51:40 -0700, Dirk Hohndel <hohndel@infradead.org> wr=
\r
51 > The following two patches should address most of the concerns raised=20
\r
52 > to my previous series.=20
\r
54 Allow me to raise new concerns then. ;-)
\r
56 > The first patch simply adds an interface to obtain a concatenation of
\r
57 > all instances of a specific header from an email.
\r
59 I was hoping to see the "special-case value of NULL" go away with this
\r
62 And I like that there's a new function to get the concatenated header,
\r
63 (I would prefer an unabbreviated name of get_concatenated_header than
\r
64 get_header_concat), but I don't like seeing all the existing callers of
\r
65 get_header updated to pass an extra 0. Instead, I'd prefer to see those
\r
66 calls unchanged, and a tiny new get_header that passes the 0 and then
\r
67 make the actual implementing function be static and named something like
\r
68 notmuch_message_file_get_header_internal.
\r
70 Both patches have some trailing whitespace. I see these easily wince I
\r
71 have the following in my ~/.gitconfig:
\r
74 whitespace =3D trailing-space,space-before-tab
\r
76 I'm sure there's a way to make git refuse to let you commit changes with
\r
77 trailing whitespace, but I don't know offhand what it is.
\r
79 Finally, I'd like to see some tests for this feature. (But we do have
\r
80 the feature already without tests, so I won't strictly block on that).
\r
82 If you can fix up any of the above before I make another pass through ym
\r
83 queue, that would be great.
\r
90 Content-Type: application/pgp-signature
\r
92 -----BEGIN PGP SIGNATURE-----
\r
93 Version: GnuPG v1.4.10 (GNU/Linux)
\r
95 iD8DBQFL0eso6JDdNq8qSWgRAseVAKCG3F2SC7JaIE8iM+Cy9B9yto57TQCeOHYx
\r
96 MQtYcLRhkdVeTN1eXSqvo20=
\r
98 -----END PGP SIGNATURE-----
\r