Re: improve from-header guessing

diff --git a/fd/9ce121472b725be65f56c5bd9f8be99ed08f30 b/fd/9ce121472b725be65f56c5bd9f8be99ed08f30
new file mode 100644 (file)
index 0000000..f201ddf
--- /dev/null
+++ b/fd/9ce121472b725be65f56c5bd9f8be99ed08f30
@@ -0,0 +1,99 @@
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 74A9A4196F5\r
+       for <notmuch@notmuchmail.org>; Fri, 23 Apr 2010 12:15:40 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.89\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.89 tagged_above=-999 required=5\r
+       tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, T_MIME_NO_TEXT=0.01]\r
+       autolearn=ham\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id AmxBHtfnQN+O; Fri, 23 Apr 2010 12:15:39 -0700 (PDT)\r
+Received: from yoom.home.cworth.org (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 667F5431FC1;\r
+       Fri, 23 Apr 2010 12:15:39 -0700 (PDT)\r
+Received: by yoom.home.cworth.org (Postfix, from userid 1000)\r
+       id 31BED568DE4; Fri, 23 Apr 2010 11:47:04 -0700 (PDT)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: Dirk Hohndel <hohndel@infradead.org>, notmuch@notmuchmail.org\r
+Subject: Re: improve from-header guessing\r
+In-Reply-To: <1271451102-11336-1-git-send-email-hohndel@infradead.org>\r
+References: <1271451102-11336-1-git-send-email-hohndel@infradead.org>\r
+Date: Fri, 23 Apr 2010 11:47:04 -0700\r
+Message-ID: <87pr1qf1lj.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 23 Apr 2010 19:15:40 -0000\r
+\r
+--=-=-=\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Fri, 16 Apr 2010 13:51:40 -0700, Dirk Hohndel <hohndel@infradead.org> wr=\r
+ote:\r
+> The following two patches should address most of the concerns raised=20\r
+> to my previous series.=20\r
+\r
+Allow me to raise new concerns then. ;-)\r
+\r
+> The first patch simply adds an interface to obtain a concatenation of\r
+> all instances of a specific header from an email.\r
+\r
+I was hoping to see the "special-case value of NULL" go away with this\r
+change.\r
+\r
+And I like that there's a new function to get the concatenated header,\r
+(I would prefer an unabbreviated name of get_concatenated_header than\r
+get_header_concat), but I don't like seeing all the existing callers of\r
+get_header updated to pass an extra 0. Instead, I'd prefer to see those\r
+calls unchanged, and a tiny new get_header that passes the 0 and then\r
+make the actual implementing function be static and named something like\r
+notmuch_message_file_get_header_internal.\r
+\r
+Both patches have some trailing whitespace. I see these easily wince I\r
+have the following in my ~/.gitconfig:\r
+\r
+       [core]\r
+               whitespace =3D trailing-space,space-before-tab\r
+\r
+I'm sure there's a way to make git refuse to let you commit changes with\r
+trailing whitespace, but I don't know offhand what it is.\r
+\r
+Finally, I'd like to see some tests for this feature. (But we do have\r
+the feature already without tests, so I won't strictly block on that).\r
+\r
+If you can fix up any of the above before I make another pass through ym\r
+queue, that would be great.\r
+\r
+Thanks,\r
+\r
+=2DCarl\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.10 (GNU/Linux)\r
+\r
+iD8DBQFL0eso6JDdNq8qSWgRAseVAKCG3F2SC7JaIE8iM+Cy9B9yto57TQCeOHYx\r
+MQtYcLRhkdVeTN1eXSqvo20=\r
+=kXpC\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r