1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 4A2DC431FB6
\r
6 for <notmuch@notmuchmail.org>; Wed, 5 Dec 2012 09:25:03 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id mPKxbhc7EVxw for <notmuch@notmuchmail.org>;
\r
16 Wed, 5 Dec 2012 09:25:02 -0800 (PST)
\r
17 Received: from mail-la0-f53.google.com (mail-la0-f53.google.com
\r
18 [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 87F90431FAE
\r
21 for <notmuch@notmuchmail.org>; Wed, 5 Dec 2012 09:25:02 -0800 (PST)
\r
22 Received: by mail-la0-f53.google.com with SMTP id w12so4624544lag.26
\r
23 for <notmuch@notmuchmail.org>; Wed, 05 Dec 2012 09:25:00 -0800 (PST)
\r
24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
25 d=google.com; s=20120113;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type:x-gm-message-state;
\r
28 bh=kkiB34AgzegAGGiGXUCc6NjefwVQ0RGokNXIbCzB9Uk=;
\r
29 b=b/9IOXRipqcUYAwrwpApqXHqEb2808kbpXgWFV/hNvuai76Gvv0OSi7e8LS3x279n+
\r
30 h1zCcwncCg04xzTBfrIQ/E65AYoD1D5TOyYiWLKrcm+2Lw9EEQ54Yg5FJnY0z+B6nwsr
\r
31 xvBckdywjDS5tsFT8jOglzfQ7VUe4WTdbC0TVXIoYdzf0bY8WEz+03TmaBYN6MKC4iXc
\r
32 1bSWKfCF+XxFBm3xKZJLNZnkRP7hTtnkIVDGenyCmVszRZvBUhf+7Q1RaFOTCiNeN1Gp
\r
33 T9QO6N4wcUjSWUVWWwgyWmR5ubzhyRfz9wlCAGFl2/zYhcvCrn5rZ6nrc3+M/3RV87Mo
\r
35 Received: by 10.152.148.197 with SMTP id tu5mr2456004lab.35.1354728298067;
\r
36 Wed, 05 Dec 2012 09:24:58 -0800 (PST)
\r
37 Received: from localhost (dsl-hkibrasgw4-fe51df00-27.dhcp.inet.fi.
\r
39 by mx.google.com with ESMTPS id fb1sm2485820lbb.15.2012.12.05.09.24.55
\r
40 (version=SSLv3 cipher=OTHER); Wed, 05 Dec 2012 09:24:56 -0800 (PST)
\r
41 From: Jani Nikula <jani@nikula.org>
\r
42 To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
43 Subject: Re: [PATCH 0/3] Use invisibility to toggle display of all parts
\r
45 In-Reply-To: <1354663662-20524-1-git-send-email-markwalters1009@gmail.com>
\r
46 References: <1354663662-20524-1-git-send-email-markwalters1009@gmail.com>
\r
47 User-Agent: Notmuch/0.14+140~gbe5119e (http://notmuchmail.org) Emacs/23.4.1
\r
49 Date: Wed, 05 Dec 2012 19:24:54 +0200
\r
50 Message-ID: <87r4n4jtsp.fsf@nikula.org>
\r
52 Content-Type: text/plain; charset=us-ascii
\r
54 ALoCoQljsWS/TpT3iqPFxaLMg2X1HQ8V+jN1XAiCFVEocr9xQQFrE1yowZaafYQDH9f43rStodmj
\r
55 X-BeenThere: notmuch@notmuchmail.org
\r
56 X-Mailman-Version: 2.1.13
\r
58 List-Id: "Use and development of the notmuch mail system."
\r
59 <notmuch.notmuchmail.org>
\r
60 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
61 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
62 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
63 List-Post: <mailto:notmuch@notmuchmail.org>
\r
64 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
65 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
66 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
67 X-List-Received-Date: Wed, 05 Dec 2012 17:25:03 -0000
\r
72 On Wed, 05 Dec 2012, Mark Walters <markwalters1009@gmail.com> wrote:
\r
73 > This patch aims to do the same as
\r
74 > id:1354496317-24564-1-git-send-email-markwalters1009@gmail.com but
\r
75 > rather than reloading the buffer it uses invisibility.
\r
77 > Most of the invisibility stuff was taken from notmuch-wash and adapted
\r
78 > to this situation.
\r
80 > The general interface is that any part can have its visibility
\r
81 > toggled: in this version by "t" on the part button. In addition "RET"
\r
82 > on the part button of any "not shown" part will show it.
\r
84 I tested the patches (did not look at the code), and with the addition
\r
85 of your RET patch on top, I think the series is perfect! I very much
\r
86 like the functionality. Must have.
\r
88 > Whilst a main driver was being able to view different parts of a
\r
89 > multipart/alternative message, this also allows the user to toggle
\r
90 > images or large inline text attachments (eg text/x-tex) for
\r
91 > example. Indeed, even multipart part buttons can be toggled which
\r
92 > remove the whole tree beneath: it is unclear whether this last is useful.
\r
94 It's very nice that this is a general solution showing/hiding parts, and
\r
95 the original multipart/alternative problem is just a special case this
\r
96 handles. And if there's any more tweaking the special case needs, it
\r
97 should be done on top of this series, afterwards.
\r
99 > The invisibility approach has some advantages over the reloading
\r
100 > approach. It does not disrupt the rest of the buffer (eg
\r
101 > collapsed/expanded citations remain), it does not require an extra
\r
102 > call to the database with the possible addition of messages to the
\r
103 > buffer, and it fits more naturally with the other hidden/not-hidden
\r
106 Yes, much better than the original (which already was good).
\r
108 Thanks for doing this.
\r
120 > Mark Walters (3):
\r
121 > emacs: show: modify insert-part-header to save the button text
\r
122 > emacs: show: add overlays for each part
\r
123 > emacs: show: add invisibility button action
\r
125 > emacs/notmuch-show.el | 117 +++++++++++++++++++++++++++++++++++++++----------
\r
126 > 1 files changed, 93 insertions(+), 24 deletions(-)
\r
131 > _______________________________________________
\r
132 > notmuch mailing list
\r
133 > notmuch@notmuchmail.org
\r
134 > http://notmuchmail.org/mailman/listinfo/notmuch
\r
projects / notmuch-archives.git / blob