From: Jani Nikula <jani@nikula.org>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/3] Use invisibility to toggle display of all parts
	including multipart
In-Reply-To: <1354663662-20524-1-git-send-email-markwalters1009@gmail.com>
References: <1354663662-20524-1-git-send-email-markwalters1009@gmail.com>
User-Agent: Notmuch/0.14+140~gbe5119e (http://notmuchmail.org) Emacs/23.4.1
	(i686-pc-linux-gnu)
Date: Wed, 05 Dec 2012 19:24:54 +0200
Message-ID: <87r4n4jtsp.fsf@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list


Hi Mark -

On Wed, 05 Dec 2012, Mark Walters <markwalters1009@gmail.com> wrote:
> This patch aims to do the same as
> id:1354496317-24564-1-git-send-email-markwalters1009@gmail.com but
> rather than reloading the buffer it uses invisibility. 
>
> Most of the invisibility stuff was taken from notmuch-wash and adapted
> to this situation.
>
> The general interface is that any part can have its visibility
> toggled: in this version by "t" on the part button. In addition "RET"
> on the part button of any "not shown" part will show it.

I tested the patches (did not look at the code), and with the addition
of your RET patch on top, I think the series is perfect! I very much
like the functionality. Must have.

> Whilst a main driver was being able to view different parts of a
> multipart/alternative message, this also allows the user to toggle
> images or large inline text attachments (eg text/x-tex) for
> example. Indeed, even multipart part buttons can be toggled which
> remove the whole tree beneath: it is unclear whether this last is useful.

It's very nice that this is a general solution showing/hiding parts, and
the original multipart/alternative problem is just a special case this
handles. And if there's any more tweaking the special case needs, it
should be done on top of this series, afterwards.

> The invisibility approach has some advantages over the reloading
> approach. It does not disrupt the rest of the buffer (eg
> collapsed/expanded citations remain), it does not require an extra
> call to the database with the possible addition of messages to the
> buffer, and it fits more naturally with the other hidden/not-hidden
> items.

Yes, much better than the original (which already was good).

Thanks for doing this.

BR,
Jani.


>
> Best wishes
>
> Mark
>
>
> Mark Walters (3):
>   emacs: show: modify insert-part-header to save the button text
>   emacs: show: add overlays for each part
>   emacs: show: add invisibility button action
>
>  emacs/notmuch-show.el |  117 +++++++++++++++++++++++++++++++++++++++----------
>  1 files changed, 93 insertions(+), 24 deletions(-)
>
> -- 
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch