f6/433c1df4764e7896f086ce475e491ce040c6a3

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id CA6EA429E21\r
   6         for <notmuch@notmuchmail.org>; Mon, 28 Nov 2011 10:26:56 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id cVgMJMmfOmB7 for <notmuch@notmuchmail.org>;\r
  16         Mon, 28 Nov 2011 10:26:56 -0800 (PST)\r
  17 Received: from dmz-mailsec-scanner-5.mit.edu (DMZ-MAILSEC-SCANNER-5.MIT.EDU\r
  18         [18.7.68.34])\r
  19         by olra.theworths.org (Postfix) with ESMTP id 51BB8431FB6\r
  20         for <notmuch@notmuchmail.org>; Mon, 28 Nov 2011 10:26:56 -0800 (PST)\r
  21 X-AuditID: 12074422-b7ff56d00000092f-08-4ed3d26e439e\r
  22 Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
  23         by dmz-mailsec-scanner-5.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id B7.02.02351.E62D3DE4; Mon, 28 Nov 2011 13:26:54 -0500 (EST)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id pASIQsWc026499; \r
  27         Mon, 28 Nov 2011 13:26:54 -0500\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id pASIQptH006361\r
  32         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
  33         Mon, 28 Nov 2011 13:26:53 -0500 (EST)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1RV5wl-0002IS-Ps; Mon, 28 Nov 2011 13:28:55 -0500\r
  37 Date: Mon, 28 Nov 2011 13:28:55 -0500\r
  38 From: Austin Clements <amdragon@MIT.EDU>\r
  39 To: Jameson Graef Rollins <jrollins@finestructure.net>\r
  40 Subject: Re: [PATCH 1/2] emacs: remove some code duplication in notmuch-show\r
  41 Message-ID: <20111128182855.GB2050@mit.edu>\r
  42 References: <1322259811-10834-1-git-send-email-dmitry.kurochkin@gmail.com>\r
  43         <87lir0xr3g.fsf@servo.finestructure.net>\r
  44 MIME-Version: 1.0\r
  45 Content-Type: text/plain; charset=us-ascii\r
  46 Content-Disposition: inline\r
  47 In-Reply-To: <87lir0xr3g.fsf@servo.finestructure.net>\r
  48 User-Agent: Mutt/1.5.21 (2010-09-15)\r
  49 X-Brightmail-Tracker:\r
  50  H4sIAAAAAAAAA+NgFupileLIzCtJLcpLzFFi42IR4hRV1s27dNnPYO4Na4urW/vZLfbs87K4\r
  51         fnMmswOzx93TXB47Z91l93i26hZzAHMUl01Kak5mWWqRvl0CV8bRZ39ZCpawVRw4cYa5gXEK\r
  52         axcjJ4eEgInElKYvLBC2mMSFe+vZuhi5OIQE9jFKHG6eyAiSEBLYwCjx7oITROIkk8T7Mx/Z\r
  53         IZwljBKd33vZQapYBFQlXn3YA2azCWhIbNu/HKxbRMBMoufLHzCbWcBLYsKnU0wgtrCAj8Tk\r
  54         BfeZuxg5OHgFtCXWTw6CWFYqMXHLMTYQm1dAUOLkzCcsEK1aEjf+vWQCKWcWkJZY/o8DJMwp\r
  55         YCrxcfl6ZhBbVEBFYsrJbWwTGIVmIemehaR7FkL3AkbmVYyyKblVurmJmTnFqcm6xcmJeXmp\r
  56         RbqmermZJXqpKaWbGEFBzu6itIPx50GlQ4wCHIxKPLyc2y/7CbEmlhVX5h5ilORgUhLllb8A\r
  57         FOJLyk+pzEgszogvKs1JLT7EKMHBrCTCyxQAlONNSaysSi3Kh0lJc7AoifNy7XTwExJITyxJ\r
  58         zU5NLUgtgsnKcHAoSfAeugjUKFiUmp5akZaZU4KQZuLgBBnOAzS8G6SGt7ggMbc4Mx0if4pR\r
  59         UUqc9zRIQgAkkVGaB9cLS0KvGMWBXhHmPQhSxQNMYHDdr4AGMwEN5ph5AWRwSSJCSqqBUaWf\r
  60         X7LPMN0p/8j++rI1k8sfPCkT6Xhfdf+Gtni000qbLJ91/tf8G+6y+1bJ+uZ1+P1aEXx0z+1F\r
  61         fd91Ns16+/44b8V1l6ofs2+YSy52S36WyRO0MfnXdd095fLdMxx4puz/n8Hzqii0QewDu2Ot\r
  62         +moJ7g9XN7LbhO79eEPl/BXOFSdZ/7doK7EUZyQaajEXFScCAG75+bkdAwAA\r
  63 Cc: notmuch@notmuchmail.org\r
  64 X-BeenThere: notmuch@notmuchmail.org\r
  65 X-Mailman-Version: 2.1.13\r
  66 Precedence: list\r
  67 List-Id: "Use and development of the notmuch mail system."\r
  68         <notmuch.notmuchmail.org>\r
  69 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  70         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  71 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  72 List-Post: <mailto:notmuch@notmuchmail.org>\r
  73 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  74 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  75         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  76 X-List-Received-Date: Mon, 28 Nov 2011 18:26:56 -0000\r
  77 \r
  78 Quoth Jameson Graef Rollins on Nov 28 at  6:24 am:\r
  79 > On Sat, 26 Nov 2011 02:23:30 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
  80 > > -(defun notmuch-show-get-header (header)\r
  81 > > +(defun notmuch-show-get-header (header &optional props)\r
  82 > >    "Return the named header of the current message, if any."\r
  83 > > -  (plist-get (notmuch-show-get-prop :headers) header))\r
  84 > > +  (plist-get (notmuch-show-get-prop :headers props) header))\r
  85 > \r
  86 > Hey, Dmitry.  It looks like the new plist-get call is assuming props is\r
  87 > defined, but it looks like it's only optional in the argument list.\r
  88 > Wouldn't the function fail if the props argument is not supplied?\r
  89 \r
  90 If props isn't provided, it'll be nil, so notmuch-show-get-prop will\r
  91 also interpret its optional props argument as not being provided.\r