1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id 05DB76DE0231
\r
6 for <notmuch@notmuchmail.org>; Wed, 10 Feb 2016 00:17:16 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=0.645 tagged_above=-999 required=5 tests=[AWL=-0.007,
\r
12 SPF_NEUTRAL=0.652] autolearn=disabled
\r
13 Received: from arlo.cworth.org ([127.0.0.1])
\r
14 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id SMagaZ6eu1Q2 for <notmuch@notmuchmail.org>;
\r
16 Wed, 10 Feb 2016 00:17:13 -0800 (PST)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by arlo.cworth.org (Postfix) with ESMTP id 819616DE021E
\r
19 for <notmuch@notmuchmail.org>; Wed, 10 Feb 2016 00:17:13 -0800 (PST)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 0991910007F;
\r
22 Wed, 10 Feb 2016 10:17:30 +0200 (EET)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Mark Walters <markwalters1009@gmail.com>, David Edmondson <dme@dme.org>,
\r
25 notmuch@notmuchmail.org
\r
26 Subject: Re: [PATCH v5 3/3] emacs: Bind filter in search to 'l'
\r
27 In-Reply-To: <87wpqd61ez.fsf@qmul.ac.uk>
\r
28 References: <1434182890-8047-1-git-send-email-markwalters1009@gmail.com>
\r
29 <1434182890-8047-4-git-send-email-markwalters1009@gmail.com>
\r
30 <m2io1x4oop.fsf@dme.org> <87wpqd61ez.fsf@qmul.ac.uk>
\r
31 User-Agent: Notmuch/0.21+32~g73439f8 (http://notmuchmail.org) Emacs/24.3.1
\r
32 (x86_64-unknown-linux-gnu)
\r
33 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
34 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
35 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
36 Date: Wed, 10 Feb 2016 10:17:29 +0200
\r
37 Message-ID: <m21t8lnfmu.fsf@guru.guru-group.fi>
\r
39 Content-Type: text/plain
\r
40 X-BeenThere: notmuch@notmuchmail.org
\r
41 X-Mailman-Version: 2.1.20
\r
43 List-Id: "Use and development of the notmuch mail system."
\r
44 <notmuch.notmuchmail.org>
\r
45 List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
\r
46 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
47 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
48 List-Post: <mailto:notmuch@notmuchmail.org>
\r
49 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
50 List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
\r
51 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
52 X-List-Received-Date: Wed, 10 Feb 2016 08:17:16 -0000
\r
54 On Tue, Feb 09 2016, Mark Walters <markwalters1009@gmail.com> wrote:
\r
56 > On Tue, 09 Feb 2016, David Edmondson <dme@dme.org> wrote:
\r
57 >> On Sat, Jun 13 2015, Mark Walters wrote:
\r
58 >>> Change the key binding for filter (or "limit") in search-mode. This
\r
59 >>> gives consistency with the new filter in show-mode, and frees 'f' for
\r
60 >>> forward-thread in the future.
\r
62 >> Is there a conclusion on this change? The patch itself seems obviously
\r
63 >> fine from a code perspective, at issue is more whether it's acceptable
\r
64 >> to change the key binding.
\r
66 >> The equivalent binding in notmuch-show mode is already "l", and I think
\r
67 >> that it makes sense to be consistent (i.e. the change should be
\r
70 > I broadly agree, particularly as it will free up f for forwarding a
\r
71 > thread in search view (which is easy to do on top of
\r
72 > id:1454931262-21362-1-git-send-email-dme@dme.org).
\r
74 > It will be annoying in the short term to learn the change, but I don't
\r
75 > see a way round that.
\r
77 In short, +1 for the change.
\r
87 >>> emacs/notmuch.el | 4 ++--
\r
88 >>> 1 file changed, 2 insertions(+), 2 deletions(-)
\r
90 >>> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
\r
91 >>> index 6564816..06e3b94 100644
\r
92 >>> --- a/emacs/notmuch.el
\r
93 >>> +++ b/emacs/notmuch.el
\r
94 >>> @@ -166,7 +166,7 @@ (defvar notmuch-search-mode-map
\r
95 >>> (define-key map "o" 'notmuch-search-toggle-order)
\r
96 >>> (define-key map "c" 'notmuch-search-stash-map)
\r
97 >>> (define-key map "t" 'notmuch-search-filter-by-tag)
\r
98 >>> - (define-key map "f" 'notmuch-search-filter)
\r
99 >>> + (define-key map "l" 'notmuch-search-filter)
\r
100 >>> (define-key map [mouse-1] 'notmuch-search-show-thread)
\r
101 >>> (define-key map "*" 'notmuch-search-tag-all)
\r
102 >>> (define-key map "a" 'notmuch-search-archive-thread)
\r
103 >>> @@ -983,7 +983,7 @@ (defun notmuch-search-toggle-order ()
\r
104 >>> (notmuch-search-refresh-view))
\r
106 >>> (defun notmuch-search-filter (query)
\r
107 >>> - "Filter the current search results based on an additional query string.
\r
108 >>> + "Filter or LIMIT the current search results based on an additional query string.
\r
110 >>> Runs a new search matching only messages that match both the
\r
111 >>> current search results AND the additional query string provided."
\r