Re: [PATCH v4 01/16] add util/search-path.{c, h} to test for executables in $PATH

diff --git a/5b/237e2bb0c2d4c0f58b773de5e322f60913798c b/5b/237e2bb0c2d4c0f58b773de5e322f60913798c
new file mode 100644 (file)
index 0000000..789313f
--- /dev/null
+++ b/5b/237e2bb0c2d4c0f58b773de5e322f60913798c
@@ -0,0 +1,77 @@
+Return-Path: <dkg@fifthhorseman.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 396C06DE0B39\r
+ for <notmuch@notmuchmail.org>; Fri, 12 Aug 2016 12:25:50 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.051\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.051 tagged_above=-999 required=5\r
+ tests=[AWL=-0.051] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id jJHyLM2WiwXq for <notmuch@notmuchmail.org>;\r
+ Fri, 12 Aug 2016 12:25:42 -0700 (PDT)\r
+Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118])\r
+ by arlo.cworth.org (Postfix) with ESMTP id CF44B6DE0B12\r
+ for <notmuch@notmuchmail.org>; Fri, 12 Aug 2016 12:25:41 -0700 (PDT)\r
+Received: from fifthhorseman.net (unknown [38.109.115.130])\r
+ by che.mayfirst.org (Postfix) with ESMTPSA id 95514F98B;\r
+ Fri, 12 Aug 2016 15:25:39 -0400 (EDT)\r
+Received: by fifthhorseman.net (Postfix, from userid 1000)\r
+ id D046820248; Fri, 12 Aug 2016 14:46:38 -0400 (EDT)\r
+From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>\r
+To: David Bremner <david@tethera.net>, Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH v4 01/16] add util/search-path.{c,\r
+ h} to test for executables in $PATH\r
+In-Reply-To: <87y442phbm.fsf@maritornes.cs.unb.ca>\r
+References: <1467970047-8013-1-git-send-email-dkg@fifthhorseman.net>\r
+ <1467970047-8013-2-git-send-email-dkg@fifthhorseman.net>\r
+ <878tw2r0vf.fsf@maritornes.cs.unb.ca>\r
+ <87k2fmse5h.fsf@alice.fifthhorseman.net>\r
+ <87y442phbm.fsf@maritornes.cs.unb.ca>\r
+User-Agent: Notmuch/0.22.1+88~g8d09e96 (https://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Fri, 12 Aug 2016 14:46:38 -0400\r
+Message-ID: <87mvkhrfjl.fsf@alice.fifthhorseman.net>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 12 Aug 2016 19:25:50 -0000\r
+\r
+On Fri 2016-08-12 03:38:53 -0400, David Bremner wrote:\r
+> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:\r
+>\r
+>>> Should we distinguish between relative and absolute paths here?  I can't\r
+>>> think of any security implications, but I'm wondering if a relative path\r
+>>> is likely just a user error.\r
+>>\r
+>> I don't think a relative path is necessarily a user error.  I certainly\r
+>> use relative paths myself from time to time.\r
+>\r
+> As configuration values? That seems quite fragile, since it depends on\r
+> the current working directory when notmuch is run.\r
+\r
+rarely!  but sometimes i do it because i'm testing things in strange\r
+ways, and it can be a bit frustrating to have a tool second-guess me\r
+when it seems like i ought to be able to drop the same string i'm using\r
+on the command line into the configuration.\r
+\r
+I don't feel strongly, though.  if you want to say that bare words found\r
+in the $PATH and absolute filenames (starting with /) are fine in the\r
+notmuch config but relative paths are not, i'd be ok with that :)\r
+\r
+        --dkg\r