1 Return-Path: <dme@dme.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id A5420429E25
\r
6 for <notmuch@notmuchmail.org>; Wed, 11 Jan 2012 00:21:06 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 9xR3oswZdoRF for <notmuch@notmuchmail.org>;
\r
16 Wed, 11 Jan 2012 00:21:04 -0800 (PST)
\r
17 Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com
\r
18 [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 900BF431FD0
\r
21 for <notmuch@notmuchmail.org>; Wed, 11 Jan 2012 00:21:04 -0800 (PST)
\r
22 Received: by wibhr12 with SMTP id hr12so191791wib.26
\r
23 for <notmuch@notmuchmail.org>; Wed, 11 Jan 2012 00:21:03 -0800 (PST)
\r
24 Received: by 10.180.81.72 with SMTP id y8mr40710743wix.14.1326270063157;
\r
25 Wed, 11 Jan 2012 00:21:03 -0800 (PST)
\r
26 Received: from hotblack-desiato.hh.sledj.net
\r
27 (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25])
\r
28 by mx.google.com with ESMTPS id 28sm761168wby.3.2012.01.11.00.21.00
\r
29 (version=TLSv1/SSLv3 cipher=OTHER);
\r
30 Wed, 11 Jan 2012 00:21:01 -0800 (PST)
\r
31 Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000)
\r
32 id 9819E9FEFA; Wed, 11 Jan 2012 08:20:59 +0000 (GMT)
\r
33 To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
\r
34 Subject: Re: [PATCH v3 2/4] emacs: add support for replying just to the sender
\r
36 <069a0cddd4e848314fb64da861b3bf5b4f053f14.1326224339.git.jani@nikula.org>
\r
37 References: <cover.1326224339.git.jani@nikula.org>
\r
38 <069a0cddd4e848314fb64da861b3bf5b4f053f14.1326224339.git.jani@nikula.org>
\r
39 User-Agent: Notmuch/0.10.2+186~gd0f7804 (http://notmuchmail.org)
\r
40 Emacs/24.0.92.1 (x86_64-pc-linux-gnu)
\r
41 From: David Edmondson <dme@dme.org>
\r
42 Date: Wed, 11 Jan 2012 08:20:56 +0000
\r
43 Message-ID: <cun39bmodjr.fsf@hotblack-desiato.hh.sledj.net>
\r
45 Content-Type: multipart/signed; boundary="=-=-=";
\r
46 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
47 X-BeenThere: notmuch@notmuchmail.org
\r
48 X-Mailman-Version: 2.1.13
\r
50 List-Id: "Use and development of the notmuch mail system."
\r
51 <notmuch.notmuchmail.org>
\r
52 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
53 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
54 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
55 List-Post: <mailto:notmuch@notmuchmail.org>
\r
56 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
57 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
58 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
59 X-List-Received-Date: Wed, 11 Jan 2012 08:21:06 -0000
\r
62 Content-Type: text/plain
\r
64 On Tue, 10 Jan 2012 21:54:02 +0200, Jani Nikula <jani@nikula.org> wrote:
\r
65 > Provide reply to sender counterparts to the search and show reply
\r
66 > functions. Add key binding 'R' to reply to sender, while keeping 'r' as
\r
67 > reply to all, both in search and show views.
\r
69 All looks fine. My only comments are nits.
\r
71 > -(defun notmuch-mua-reply (query-string &optional sender)
\r
72 > +(defun notmuch-mua-reply (query-string &optional sender reply-all)
\r
75 > (args '("reply")))
\r
76 > (if notmuch-show-process-crypto
\r
77 > (setq args (append args '("--decrypt"))))
\r
79 > + (setq args (append args '("--reply-to=all")))
\r
80 > + (setq args (append args '("--reply-to=sender"))))
\r
81 > (setq args (append args (list query-string)))
\r
83 I don't like how this ends up. How about something like:
\r
85 (defun notmuch-mua-reply (query-string &optional sender)
\r
88 (args (nconc (list "reply"
\r
89 (concat "--reply-to="
\r
90 (if reply-all "all" "sender")))
\r
91 (when notmuch-show-process-crypto
\r
93 (list query-string))))
\r
95 But even that is not very nice.
\r
98 Content-Type: application/pgp-signature
\r
100 -----BEGIN PGP SIGNATURE-----
\r
101 Version: GnuPG v1.4.11 (GNU/Linux)
\r
103 iEYEARECAAYFAk8NRmgACgkQaezQq/BJZRY3QwCeKLTkza6GUErEQF1eZUvvcmSG
\r
104 aLsAn3MBsG5e6wITaJcuUCLpRofWe3Op
\r
106 -----END PGP SIGNATURE-----
\r