Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id A5420429E25 for ; Wed, 11 Jan 2012 00:21:06 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9xR3oswZdoRF for ; Wed, 11 Jan 2012 00:21:04 -0800 (PST) Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 900BF431FD0 for ; Wed, 11 Jan 2012 00:21:04 -0800 (PST) Received: by wibhr12 with SMTP id hr12so191791wib.26 for ; Wed, 11 Jan 2012 00:21:03 -0800 (PST) Received: by 10.180.81.72 with SMTP id y8mr40710743wix.14.1326270063157; Wed, 11 Jan 2012 00:21:03 -0800 (PST) Received: from hotblack-desiato.hh.sledj.net (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25]) by mx.google.com with ESMTPS id 28sm761168wby.3.2012.01.11.00.21.00 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 11 Jan 2012 00:21:01 -0800 (PST) Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000) id 9819E9FEFA; Wed, 11 Jan 2012 08:20:59 +0000 (GMT) To: Jani Nikula , notmuch@notmuchmail.org Subject: Re: [PATCH v3 2/4] emacs: add support for replying just to the sender In-Reply-To: <069a0cddd4e848314fb64da861b3bf5b4f053f14.1326224339.git.jani@nikula.org> References: <069a0cddd4e848314fb64da861b3bf5b4f053f14.1326224339.git.jani@nikula.org> User-Agent: Notmuch/0.10.2+186~gd0f7804 (http://notmuchmail.org) Emacs/24.0.92.1 (x86_64-pc-linux-gnu) From: David Edmondson Date: Wed, 11 Jan 2012 08:20:56 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2012 08:21:06 -0000 --=-=-= Content-Type: text/plain On Tue, 10 Jan 2012 21:54:02 +0200, Jani Nikula wrote: > Provide reply to sender counterparts to the search and show reply > functions. Add key binding 'R' to reply to sender, while keeping 'r' as > reply to all, both in search and show views. All looks fine. My only comments are nits. > -(defun notmuch-mua-reply (query-string &optional sender) > +(defun notmuch-mua-reply (query-string &optional sender reply-all) > (let (headers > body > (args '("reply"))) > (if notmuch-show-process-crypto > (setq args (append args '("--decrypt")))) > + (if reply-all > + (setq args (append args '("--reply-to=all"))) > + (setq args (append args '("--reply-to=sender")))) > (setq args (append args (list query-string))) I don't like how this ends up. How about something like: (defun notmuch-mua-reply (query-string &optional sender) (let (headers body (args (nconc (list "reply" (concat "--reply-to=" (if reply-all "all" "sender"))) (when notmuch-show-process-crypto (list "--decrypt")) (list query-string)))) But even that is not very nice. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk8NRmgACgkQaezQq/BJZRY3QwCeKLTkza6GUErEQF1eZUvvcmSG aLsAn3MBsG5e6wITaJcuUCLpRofWe3Op =+3dI -----END PGP SIGNATURE----- --=-=-=--