1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 16A39431E64
\r
6 for <notmuch@notmuchmail.org>; Sun, 2 Jun 2013 10:37:01 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id 9Lp7dOWzaLeE for <notmuch@notmuchmail.org>;
\r
17 Sun, 2 Jun 2013 10:36:53 -0700 (PDT)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 63776431FBC
\r
22 for <notmuch@notmuchmail.org>; Sun, 2 Jun 2013 10:36:53 -0700 (PDT)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1UjCD5-00045w-Lb; Sun, 02 Jun 2013 18:36:51 +0100
\r
27 Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)
\r
28 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)
\r
29 (envelope-from <m.walters@qmul.ac.uk>)
\r
30 id 1UjCD4-0003x5-0e; Sun, 02 Jun 2013 18:36:51 +0100
\r
31 From: Mark Walters <markwalters1009@gmail.com>
\r
32 To: david@tethera.net, notmuch@notmuchmail.org
\r
33 Subject: Re: [PATCH] emacs: replace (funcall 'foo ...) with (foo ...)
\r
34 In-Reply-To: <1370175370-13561-1-git-send-email-david@tethera.net>
\r
35 References: <1370175370-13561-1-git-send-email-david@tethera.net>
\r
36 User-Agent: Notmuch/0.14+255~gff3cc55 (http://notmuchmail.org) Emacs/23.4.1
\r
38 Date: Sun, 02 Jun 2013 18:36:39 +0100
\r
39 Message-ID: <8761xwv2hk.fsf@qmul.ac.uk>
\r
41 Content-Type: text/plain; charset=us-ascii
\r
42 X-Sender-Host-Address: 93.97.24.31
\r
43 X-QM-SPAM-Info: Sender has good ham record. :)
\r
44 X-QM-Body-MD5: dcfcf0cdc0d1eabaa38588e30dcacadb (of first 20000 bytes)
\r
45 X-SpamAssassin-Score: -0.0
\r
46 X-SpamAssassin-SpamBar: /
\r
47 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
49 spam. We require at least 5.0 points to mark a message as spam.
\r
50 This message scored -0.0 points.
\r
51 Summary of the scoring:
\r
52 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
53 provider * (markwalters1009[at]gmail.com)
\r
54 * -0.0 AWL AWL: From: address is in the auto white-list
\r
55 X-QM-Scan-Virus: ClamAV says the message is clean
\r
56 Cc: David Bremner <bremner@debian.org>
\r
57 X-BeenThere: notmuch@notmuchmail.org
\r
58 X-Mailman-Version: 2.1.13
\r
60 List-Id: "Use and development of the notmuch mail system."
\r
61 <notmuch.notmuchmail.org>
\r
62 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
64 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
65 List-Post: <mailto:notmuch@notmuchmail.org>
\r
66 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
67 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
68 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
69 X-List-Received-Date: Sun, 02 Jun 2013 17:37:01 -0000
\r
72 This looks good to me +1
\r
76 On Sun, 02 Jun 2013, david@tethera.net wrote:
\r
77 > From: David Bremner <bremner@debian.org>
\r
79 > I can't see any benefit to the funcall, and it looks like the result
\r
80 > of cut-and-paste from some code that actually used a variable for the
\r
84 > Mark and I were discussing some style issues in the context of pick,
\r
85 > and it seems to me that some of the elisp style in the current code
\r
86 > could be improved. I don't claim to be an elisp style expert by any
\r
87 > stretch of the imagination. It would be great if some experts could
\r
88 > add a section to devel/STYLE about elisp.
\r
91 > emacs/notmuch-message.el | 2 +-
\r
92 > emacs/notmuch-show.el | 6 +++---
\r
93 > emacs/notmuch.el | 4 ++--
\r
94 > 3 files changed, 6 insertions(+), 6 deletions(-)
\r
96 > diff --git a/emacs/notmuch-message.el b/emacs/notmuch-message.el
\r
97 > index 4dc4883..914bdd1 100644
\r
98 > --- a/emacs/notmuch-message.el
\r
99 > +++ b/emacs/notmuch-message.el
\r
100 > @@ -40,7 +40,7 @@ the \"inbox\" and \"todo\" tags, you would set:
\r
101 > ;; get the in-reply-to header and parse it for the message id.
\r
102 > (let ((rep (mail-header-parse-addresses (message-field-value "In-Reply-To"))))
\r
103 > (when (and notmuch-message-replied-tags rep)
\r
104 > - (funcall 'notmuch-tag (notmuch-id-to-query (car (car rep)))
\r
105 > + (notmuch-tag (notmuch-id-to-query (car (car rep)))
\r
106 > (notmuch-tag-change-list notmuch-message-replied-tags)))))
\r
108 > (add-hook 'message-send-hook 'notmuch-message-mark-replied)
\r
109 > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
\r
110 > index 613e666..18b4671 100644
\r
111 > --- a/emacs/notmuch-show.el
\r
112 > +++ b/emacs/notmuch-show.el
\r
113 > @@ -1726,7 +1726,7 @@ TAG-CHANGES is a list of tag operations for `notmuch-tag'."
\r
114 > (let* ((current-tags (notmuch-show-get-tags))
\r
115 > (new-tags (notmuch-update-tags current-tags tag-changes)))
\r
116 > (unless (equal current-tags new-tags)
\r
117 > - (funcall 'notmuch-tag (notmuch-show-get-message-id) tag-changes)
\r
118 > + (notmuch-tag (notmuch-show-get-message-id) tag-changes)
\r
119 > (notmuch-show-set-tags new-tags))))
\r
121 > (defun notmuch-show-tag (&optional tag-changes)
\r
122 > @@ -1734,7 +1734,7 @@ TAG-CHANGES is a list of tag operations for `notmuch-tag'."
\r
124 > See `notmuch-tag' for information on the format of TAG-CHANGES."
\r
126 > - (setq tag-changes (funcall 'notmuch-tag (notmuch-show-get-message-id) tag-changes))
\r
127 > + (setq tag-changes (notmuch-tag (notmuch-show-get-message-id) tag-changes))
\r
128 > (let* ((current-tags (notmuch-show-get-tags))
\r
129 > (new-tags (notmuch-update-tags current-tags tag-changes)))
\r
130 > (unless (equal current-tags new-tags)
\r
131 > @@ -1745,7 +1745,7 @@ See `notmuch-tag' for information on the format of TAG-CHANGES."
\r
133 > See `notmuch-tag' for information on the format of TAG-CHANGES."
\r
135 > - (setq tag-changes (funcall 'notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes))
\r
136 > + (setq tag-changes (notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes))
\r
137 > (notmuch-show-mapc
\r
139 > (let* ((current-tags (notmuch-show-get-tags))
\r
140 > diff --git a/emacs/notmuch.el b/emacs/notmuch.el
\r
141 > index 5a8c957..af107e2 100644
\r
142 > --- a/emacs/notmuch.el
\r
143 > +++ b/emacs/notmuch.el
\r
144 > @@ -562,7 +562,7 @@ will be signaled."
\r
145 > (defun notmuch-search-tag-region (beg end &optional tag-changes)
\r
146 > "Change tags for threads in the given region."
\r
147 > (let ((search-string (notmuch-search-find-thread-id-region-search beg end)))
\r
148 > - (setq tag-changes (funcall 'notmuch-tag search-string tag-changes))
\r
149 > + (setq tag-changes (notmuch-tag search-string tag-changes))
\r
150 > (notmuch-search-foreach-result beg end
\r
152 > (notmuch-search-set-tags
\r
153 > @@ -576,7 +576,7 @@ See `notmuch-tag' for information on the format of TAG-CHANGES."
\r
155 > (let* ((beg (if (region-active-p) (region-beginning) (point)))
\r
156 > (end (if (region-active-p) (region-end) (point))))
\r
157 > - (funcall 'notmuch-search-tag-region beg end tag-changes)))
\r
158 > + (notmuch-search-tag-region beg end tag-changes)))
\r
160 > (defun notmuch-search-add-tag ()
\r
161 > "Same as `notmuch-search-tag' but sets initial input to '+'."
\r
165 > _______________________________________________
\r
166 > notmuch mailing list
\r
167 > notmuch@notmuchmail.org
\r
168 > http://notmuchmail.org/mailman/listinfo/notmuch
\r