From: Mark Walters <markwalters1009@gmail.com>
To: david@tethera.net, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: replace (funcall 'foo ...) with (foo ...)
In-Reply-To: <1370175370-13561-1-git-send-email-david@tethera.net>
References: <1370175370-13561-1-git-send-email-david@tethera.net>
User-Agent: Notmuch/0.14+255~gff3cc55 (http://notmuchmail.org) Emacs/23.4.1
	(i486-pc-linux-gnu)
Date: Sun, 02 Jun 2013 18:36:39 +0100
Message-ID: <8761xwv2hk.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: David Bremner <bremner@debian.org>
Precedence: list


This looks good to me +1

Mark

On Sun, 02 Jun 2013, david@tethera.net wrote:
> From: David Bremner <bremner@debian.org>
>
> I can't see any benefit to the funcall, and it looks like the result
> of cut-and-paste from some code that actually used a variable for the
> function to call.
> ---
>
> Mark and I were discussing some style issues in the context of pick,
> and it seems to me that some of the elisp style in the current code
> could be improved. I don't claim to be an elisp style expert by any
> stretch of the imagination. It would be great if some experts could
> add a section to devel/STYLE about elisp.
>
>
>  emacs/notmuch-message.el | 2 +-
>  emacs/notmuch-show.el    | 6 +++---
>  emacs/notmuch.el         | 4 ++--
>  3 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/emacs/notmuch-message.el b/emacs/notmuch-message.el
> index 4dc4883..914bdd1 100644
> --- a/emacs/notmuch-message.el
> +++ b/emacs/notmuch-message.el
> @@ -40,7 +40,7 @@ the \"inbox\" and \"todo\" tags, you would set:
>    ;; get the in-reply-to header and parse it for the message id.
>    (let ((rep (mail-header-parse-addresses (message-field-value "In-Reply-To"))))
>      (when (and notmuch-message-replied-tags rep)
> -      (funcall 'notmuch-tag (notmuch-id-to-query (car (car rep)))
> +      (notmuch-tag (notmuch-id-to-query (car (car rep)))
>  	       (notmuch-tag-change-list notmuch-message-replied-tags)))))
>  
>  (add-hook 'message-send-hook 'notmuch-message-mark-replied)
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 613e666..18b4671 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -1726,7 +1726,7 @@ TAG-CHANGES is a list of tag operations for `notmuch-tag'."
>    (let* ((current-tags (notmuch-show-get-tags))
>  	 (new-tags (notmuch-update-tags current-tags tag-changes)))
>      (unless (equal current-tags new-tags)
> -      (funcall 'notmuch-tag (notmuch-show-get-message-id) tag-changes)
> +      (notmuch-tag (notmuch-show-get-message-id) tag-changes)
>        (notmuch-show-set-tags new-tags))))
>  
>  (defun notmuch-show-tag (&optional tag-changes)
> @@ -1734,7 +1734,7 @@ TAG-CHANGES is a list of tag operations for `notmuch-tag'."
>  
>  See `notmuch-tag' for information on the format of TAG-CHANGES."
>    (interactive)
> -  (setq tag-changes (funcall 'notmuch-tag (notmuch-show-get-message-id) tag-changes))
> +  (setq tag-changes (notmuch-tag (notmuch-show-get-message-id) tag-changes))
>    (let* ((current-tags (notmuch-show-get-tags))
>  	 (new-tags (notmuch-update-tags current-tags tag-changes)))
>      (unless (equal current-tags new-tags)
> @@ -1745,7 +1745,7 @@ See `notmuch-tag' for information on the format of TAG-CHANGES."
>  
>  See `notmuch-tag' for information on the format of TAG-CHANGES."
>    (interactive)
> -  (setq tag-changes (funcall 'notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes))
> +  (setq tag-changes (notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes))
>    (notmuch-show-mapc
>     (lambda ()
>       (let* ((current-tags (notmuch-show-get-tags))
> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
> index 5a8c957..af107e2 100644
> --- a/emacs/notmuch.el
> +++ b/emacs/notmuch.el
> @@ -562,7 +562,7 @@ will be signaled."
>  (defun notmuch-search-tag-region (beg end &optional tag-changes)
>    "Change tags for threads in the given region."
>    (let ((search-string (notmuch-search-find-thread-id-region-search beg end)))
> -    (setq tag-changes (funcall 'notmuch-tag search-string tag-changes))
> +    (setq tag-changes (notmuch-tag search-string tag-changes))
>      (notmuch-search-foreach-result beg end
>        (lambda (pos)
>  	(notmuch-search-set-tags
> @@ -576,7 +576,7 @@ See `notmuch-tag' for information on the format of TAG-CHANGES."
>    (interactive)
>    (let* ((beg (if (region-active-p) (region-beginning) (point)))
>  	 (end (if (region-active-p) (region-end) (point))))
> -    (funcall 'notmuch-search-tag-region beg end tag-changes)))
> +    (notmuch-search-tag-region beg end tag-changes)))
>  
>  (defun notmuch-search-add-tag ()
>    "Same as `notmuch-search-tag' but sets initial input to '+'."
> -- 
> 1.8.2.rc2
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch