1 Return-Path: <tomi.ollila@nixu.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 716CF429E25
\r
6 for <notmuch@notmuchmail.org>; Tue, 29 Nov 2011 06:48:59 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id jjB0YH+S7cR3 for <notmuch@notmuchmail.org>;
\r
16 Tue, 29 Nov 2011 06:48:58 -0800 (PST)
\r
17 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])
\r
18 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 9F158431FB6
\r
21 for <notmuch@notmuchmail.org>; Tue, 29 Nov 2011 06:48:58 -0800 (PST)
\r
22 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])
\r
23 by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id
\r
24 pATEmtXx013096; Tue, 29 Nov 2011 16:48:55 +0200
\r
25 From: Tomi Ollila <tomi.ollila@nixu.com>
\r
26 To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
\r
27 Subject: Re: [PATCH 4/4] test: fix error messages for missing binary
\r
29 In-Reply-To: <1322520067-15227-5-git-send-email-dmitry.kurochkin@gmail.com>
\r
30 References: <1322520067-15227-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
31 <1322520067-15227-5-git-send-email-dmitry.kurochkin@gmail.com>
\r
32 User-Agent: Notmuch/0.10+15~gb5803e9 (http://notmuchmail.org) Emacs/23.3.1
\r
34 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
35 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
36 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
37 Date: Tue, 29 Nov 2011 16:48:55 +0200
\r
38 Message-ID: <yf6d3cbm1bc.fsf@taco2.nixu.fi>
\r
40 Content-Type: text/plain; charset=us-ascii
\r
41 X-BeenThere: notmuch@notmuchmail.org
\r
42 X-Mailman-Version: 2.1.13
\r
44 List-Id: "Use and development of the notmuch mail system."
\r
45 <notmuch.notmuchmail.org>
\r
46 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
47 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
48 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
49 List-Post: <mailto:notmuch@notmuchmail.org>
\r
50 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
51 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
52 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
53 X-List-Received-Date: Tue, 29 Nov 2011 14:48:59 -0000
\r
59 On Tue, 29 Nov 2011 02:41:07 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
60 > The fake missing binary functions check if the binary has already be
\r
61 > added to the diagnostic message to avoid duplicates. Unfortunately,
\r
62 > this check was buggy because the message string does not have the
\r
65 > test/test-lib.sh | 2 +-
\r
66 > 1 files changed, 1 insertions(+), 1 deletions(-)
\r
68 > diff --git a/test/test-lib.sh b/test/test-lib.sh
\r
69 > index 2861d88..a975957 100644
\r
70 > --- a/test/test-lib.sh
\r
71 > +++ b/test/test-lib.sh
\r
72 > @@ -556,7 +556,7 @@ test_declare_external_prereq () {
\r
73 > hash $binary 2>/dev/null || eval "
\r
74 > test_missing_external_prereq_${binary}_=t
\r
76 > - echo -n \"\$test_subtest_missing_external_prereqs_\" | grep -qe \" $name \" ||
\r
77 > + echo -n \"\$test_subtest_missing_external_prereqs_ \" | grep -qe \" $name \" ||
\r
78 > test_subtest_missing_external_prereqs_=\"\$test_subtest_missing_external_prereqs_ $name\"
\r
84 > _______________________________________________
\r
85 > notmuch mailing list
\r
86 > notmuch@notmuchmail.org
\r
87 > http://notmuchmail.org/mailman/listinfo/notmuch
\r
91 Tomi Ollila !! tomi.ollila@nixu.fi !! +358 400 888 366
\r
92 Nixu Oy !! http://www.nixu.fi/ !! Keilaranta 15, FI-02150 Espoo, Finland
\r