From: Tomi Ollila <tomi.ollila@nixu.com>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 4/4] test: fix error messages for missing binary
	dependencies
In-Reply-To: <1322520067-15227-5-git-send-email-dmitry.kurochkin@gmail.com>
References: <1322520067-15227-1-git-send-email-dmitry.kurochkin@gmail.com>
	<1322520067-15227-5-git-send-email-dmitry.kurochkin@gmail.com>
User-Agent: Notmuch/0.10+15~gb5803e9 (http://notmuchmail.org) Emacs/23.3.1
	(i686-pc-linux-gnu)
Date: Tue, 29 Nov 2011 16:48:55 +0200
Message-ID: <yf6d3cbm1bc.fsf@taco2.nixu.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list


LGTM


On Tue, 29 Nov 2011 02:41:07 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> The fake missing binary functions check if the binary has already be
> added to the diagnostic message to avoid duplicates.  Unfortunately,
> this check was buggy because the message string does not have the
> trailing space.
> ---
>  test/test-lib.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/test/test-lib.sh b/test/test-lib.sh
> index 2861d88..a975957 100644
> --- a/test/test-lib.sh
> +++ b/test/test-lib.sh
> @@ -556,7 +556,7 @@ test_declare_external_prereq () {
>  	hash $binary 2>/dev/null || eval "
>  	test_missing_external_prereq_${binary}_=t
>  $binary () {
> -	echo -n \"\$test_subtest_missing_external_prereqs_\" | grep -qe \" $name \" ||
> +	echo -n \"\$test_subtest_missing_external_prereqs_ \" | grep -qe \" $name \" ||
>  	test_subtest_missing_external_prereqs_=\"\$test_subtest_missing_external_prereqs_ $name\"
>  	false
>  }"
> -- 
> 1.7.7.3
> 
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
> 

-- 
Tomi Ollila !! tomi.ollila@nixu.fi !! +358 400 888 366
Nixu Oy !! http://www.nixu.fi/ !! Keilaranta 15, FI-02150 Espoo, Finland