1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 1E6D8431FB6
\r
6 for <notmuch@notmuchmail.org>; Fri, 4 May 2012 11:43:24 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id NemnAhXBtAO7 for <notmuch@notmuchmail.org>;
\r
16 Fri, 4 May 2012 11:43:23 -0700 (PDT)
\r
17 Received: from dmz-mailsec-scanner-1.mit.edu (DMZ-MAILSEC-SCANNER-1.MIT.EDU
\r
19 by olra.theworths.org (Postfix) with ESMTP id 781F3431FAE
\r
20 for <notmuch@notmuchmail.org>; Fri, 4 May 2012 11:43:23 -0700 (PDT)
\r
21 X-AuditID: 1209190c-b7fad6d000000920-54-4fa4234ab509
\r
22 Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])
\r
23 by dmz-mailsec-scanner-1.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id BE.9D.02336.A4324AF4; Fri, 4 May 2012 14:43:23 -0400 (EDT)
\r
25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])
\r
26 by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id q44IhLjI002770;
\r
27 Fri, 4 May 2012 14:43:22 -0400
\r
28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
29 (authenticated bits=0)
\r
30 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
31 by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q44IhKv9009567
\r
32 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
\r
33 Fri, 4 May 2012 14:43:21 -0400 (EDT)
\r
34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)
\r
35 (envelope-from <amdragon@MIT.EDU>)
\r
36 id 1SQNTM-0005Mc-GK; Fri, 04 May 2012 14:43:20 -0400
\r
37 Date: Fri, 4 May 2012 14:43:20 -0400
\r
38 From: Austin Clements <amdragon@MIT.EDU>
\r
39 To: Justus Winter <4winter@informatik.uni-hamburg.de>
\r
40 Subject: Re: [PATCH 1/5] go: reorganize the go bindings
\r
41 Message-ID: <20120504184320.GO2704@mit.edu>
\r
42 References: <20120430195420.2528.48612@thinkbox.jade-hamburg.de>
\r
43 <1335815744-15258-1-git-send-email-4winter@informatik.uni-hamburg.de>
\r
44 <20120504183822.GN2704@mit.edu>
\r
46 Content-Type: text/plain; charset=us-ascii
\r
47 Content-Disposition: inline
\r
48 In-Reply-To: <20120504183822.GN2704@mit.edu>
\r
49 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
50 X-Brightmail-Tracker:
\r
51 H4sIAAAAAAAAA+NgFupnleLIzCtJLcpLzFFi42IRYrdT0fVWXuJvsP05k8Xs1h9MFtdvzmR2
\r
52 YPKYeP40m8ezVbeYA5iiuGxSUnMyy1KL9O0SuDLOf/3GWvCXreL08oIGxn2sXYwcHBICJhIX
\r
53 mi27GDmBTDGJC/fWs3UxcnEICexjlPh08gwrhLOeUeLtq05mCOcEk8Tfmz+hypYwSlxY8YUd
\r
54 pJ9FQEVi84u/LCA2m4CGxLb9yxlBbBEBU4kNDx6A1TALSEt8+93MBGILC5hLzJ7ykg3E5hXQ
\r
55 lnj96zs7xNBVjBLre/oYIRKCEidnPmGBaNaSuPHvJRPI3SCDlv/jAAlzCuhI3FuwGqxcFOiG
\r
56 KSe3sU1gFJqFpHsWku5ZCN0LGJlXMcqm5Fbp5iZm5hSnJusWJyfm5aUW6Rrq5WaW6KWmlG5i
\r
57 BIU1pyTPDsY3B5UOMQpwMCrx8O7mWOIvxJpYVlyZe4hRkoNJSZQ3QB4oxJeUn1KZkVicEV9U
\r
58 mpNafIhRgoNZSYQ36etifyHelMTKqtSifJiUNAeLkjivitY7PyGB9MSS1OzU1ILUIpisDAeH
\r
59 kgSvuhLQUMGi1PTUirTMnBKENBMHJ8hwHqDhHCA1vMUFibnFmekQ+VOMuhzzpmy9yijEkpef
\r
60 lyolzssJUiQAUpRRmgc3B5aOXjGKA70lzCsGUsUDTGVwk14BLWECWiJtsAhkSUkiQkqqgXFH
\r
61 pU+6T8NRt7ka7n6VSXGqpabhKXe6H22yUj53L/y07MEvJ2w/eBRYTPTq1+P0+3fz0YOKgLOa
\r
62 3Lu9zrz6EdN19O7xYl2/xTMcL1dYK70OKHptuSLz67IVtgxnTEN4t/kW8Jw52qPE9v3Cmuss
\r
63 0i+vpq9KOxj648TCp+/Uebyvx92VPWXSraTEUpyRaKjFXFScCADNgzFEIgMAAA==
\r
64 Cc: notmuch@notmuchmail.org
\r
65 X-BeenThere: notmuch@notmuchmail.org
\r
66 X-Mailman-Version: 2.1.13
\r
68 List-Id: "Use and development of the notmuch mail system."
\r
69 <notmuch.notmuchmail.org>
\r
70 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
71 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
72 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
73 List-Post: <mailto:notmuch@notmuchmail.org>
\r
74 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
75 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
76 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
77 X-List-Received-Date: Fri, 04 May 2012 18:43:24 -0000
\r
79 Quoth myself on May 04 at 2:38 pm:
\r
80 > Quoth Justus Winter on Apr 30 at 9:55 pm:
\r
81 > > Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
\r
83 > Whole series LGTM (and yay gofmt!). I have only two minor comments.
\r
85 > It would be nice to have a little more log message for some of these.
\r
86 > Mostly the first one could use some explanation of why you're
\r
87 > rearranging the source tree and a mention that there are no changes to
\r
88 > the files (since this is hard to get from the diff).
\r
90 > It would also be nice if this could optionally be built using the
\r
91 > libnotmuch and notmuch.h directly from the source tree containing the
\r
92 > Go bindings, rather than requiring them to be installed system-wide.
\r
93 > I don't know Go 1's build system well enough to know if there's an
\r
94 > easy way to do this.
\r
96 Oh, also a news patch would be good, though that can obviously be
\r