Date: Fri, 4 May 2012 14:43:20 -0400
From: Austin Clements <amdragon@MIT.EDU>
To: Justus Winter <4winter@informatik.uni-hamburg.de>
Subject: Re: [PATCH 1/5] go: reorganize the go bindings
Message-ID: <20120504184320.GO2704@mit.edu>
References: <20120430195420.2528.48612@thinkbox.jade-hamburg.de>
	<1335815744-15258-1-git-send-email-4winter@informatik.uni-hamburg.de>
	<20120504183822.GN2704@mit.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120504183822.GN2704@mit.edu>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: notmuch@notmuchmail.org
Precedence: list

Quoth myself on May 04 at  2:38 pm:
> Quoth Justus Winter on Apr 30 at  9:55 pm:
> > Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
> 
> Whole series LGTM (and yay gofmt!).  I have only two minor comments.
> 
> It would be nice to have a little more log message for some of these.
> Mostly the first one could use some explanation of why you're
> rearranging the source tree and a mention that there are no changes to
> the files (since this is hard to get from the diff).
> 
> It would also be nice if this could optionally be built using the
> libnotmuch and notmuch.h directly from the source tree containing the
> Go bindings, rather than requiring them to be installed system-wide.
> I don't know Go 1's build system well enough to know if there's an
> easy way to do this.

Oh, also a news patch would be good, though that can obviously be
separate.