1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 23DB7431FB6
\r
6 for <notmuch@notmuchmail.org>; Wed, 7 Mar 2012 12:18:14 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 73CtQ2ieBxKe for <notmuch@notmuchmail.org>;
\r
16 Wed, 7 Mar 2012 12:18:13 -0800 (PST)
\r
17 Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 1F821431FAE
\r
19 for <notmuch@notmuchmail.org>; Wed, 7 Mar 2012 12:18:13 -0800 (PST)
\r
20 Received: by guru.guru-group.fi (Postfix, from userid 501)
\r
21 id 4605D68055; Wed, 7 Mar 2012 22:18:11 +0200 (EET)
\r
22 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
23 To: Mark Walters <markwalters1009@gmail.com>,
\r
24 Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH v2 3/8] show: Allow formatters to return errors
\r
26 In-Reply-To: <87ipihbf0w.fsf@qmul.ac.uk>
\r
27 References: <1330752025-2542-1-git-send-email-amdragon@mit.edu>
\r
28 <1331059724-14653-1-git-send-email-amdragon@mit.edu>
\r
29 <1331059724-14653-4-git-send-email-amdragon@mit.edu>
\r
30 <87ipihbf0w.fsf@qmul.ac.uk>
\r
31 User-Agent: Notmuch/0.11.1+288~g4b3af0e (http://notmuchmail.org) Emacs/23.3.1
\r
32 (x86_64-unknown-linux-gnu)
\r
33 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
34 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
35 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
36 Date: Wed, 07 Mar 2012 22:18:11 +0200
\r
37 Message-ID: <m2y5rc6u7w.fsf@guru.guru-group.fi>
\r
39 Content-Type: text/plain; charset=us-ascii
\r
40 X-BeenThere: notmuch@notmuchmail.org
\r
41 X-Mailman-Version: 2.1.13
\r
43 List-Id: "Use and development of the notmuch mail system."
\r
44 <notmuch.notmuchmail.org>
\r
45 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
46 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
47 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
48 List-Post: <mailto:notmuch@notmuchmail.org>
\r
49 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
50 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
51 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
52 X-List-Received-Date: Wed, 07 Mar 2012 20:18:14 -0000
\r
54 On Tue, 06 Mar 2012 21:22:55 +0000, Mark Walters <markwalters1009@gmail.com> wrote:
\r
55 > On Tue, 6 Mar 2012 18:48:39 +0000, Austin Clements <amdragon@MIT.EDU> wrote:
\r
56 > > Formatter errors are propagated to the exit status of notmuch show.
\r
58 > > This isn't used by the JSON or text formatters, but it will be useful
\r
59 > > for the raw format, which is pickier.
\r
61 > I am not very familiar with this part of the code but the whole series
\r
64 Looks good to me too.
\r
67 > My only minor comment is that I like Tom's suggestion (in
\r
68 > id:"m2399qrtat.fsf@guru.guru-group.fi") of having NOTMUCH_STATUS_FAILURE
\r
69 > (= 1) to make the error handling look cleaner. Alternatively (or
\r
70 > possibly as well) the functions do_show and do_show_messages could pass
\r
71 > the actual error back up to notmuch_show_command and then that function
\r
72 > could convert return 0/1 as appropriate.
\r
74 > As usual I am quite happy to be overruled!
\r
76 As usual I no longer know why I suggested that in the first place
\r
77 (at least in the context of these patches ;D)
\r