From: Tomi Ollila <tomi.ollila@iki.fi>
To: Mark Walters <markwalters1009@gmail.com>,
	Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 3/8] show: Allow formatters to return errors
In-Reply-To: <87ipihbf0w.fsf@qmul.ac.uk>
References: <1330752025-2542-1-git-send-email-amdragon@mit.edu>
	<1331059724-14653-1-git-send-email-amdragon@mit.edu>
	<1331059724-14653-4-git-send-email-amdragon@mit.edu>
	<87ipihbf0w.fsf@qmul.ac.uk>
User-Agent: Notmuch/0.11.1+288~g4b3af0e (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-unknown-linux-gnu)
Date: Wed, 07 Mar 2012 22:18:11 +0200
Message-ID: <m2y5rc6u7w.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Tue, 06 Mar 2012 21:22:55 +0000, Mark Walters <markwalters1009@gmail.com> wrote:
> On Tue,  6 Mar 2012 18:48:39 +0000, Austin Clements <amdragon@MIT.EDU> wrote:
> > Formatter errors are propagated to the exit status of notmuch show.
> > 
> > This isn't used by the JSON or text formatters, but it will be useful
> > for the raw format, which is pickier.
> 
> I am not very familiar with this part of the code but the whole series
> looks fine to me.

Looks good to me too.

> 
> My only minor comment is that I like Tom's suggestion (in
> id:"m2399qrtat.fsf@guru.guru-group.fi") of having NOTMUCH_STATUS_FAILURE
> (= 1) to make the error handling look cleaner. Alternatively (or
> possibly as well) the functions do_show and do_show_messages could pass
> the actual error back up to notmuch_show_command and then that function
> could convert return 0/1 as appropriate.
> 
> As usual I am quite happy to be overruled!

As usual I no longer know why I suggested that in the first place
(at least in the context of these patches ;D)

> Best wishes
> 
> Mark

Tomi