b9/70ff5c64d64ba2415f399d2b557072d2cfef05

   1 Return-Path: <mpn@google.com>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 4A5B7431FB6\r
   6         for <notmuch@notmuchmail.org>; Mon,  3 Sep 2012 08:36:23 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7]\r
  13         autolearn=disabled\r
  14 Received: from olra.theworths.org ([127.0.0.1])\r
  15         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  16         with ESMTP id 4XG4eWRjZ6cb for <notmuch@notmuchmail.org>;\r
  17         Mon,  3 Sep 2012 08:36:22 -0700 (PDT)\r
  18 Received: from mail-ee0-f53.google.com (mail-ee0-f53.google.com\r
  19  [74.125.83.53])        (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
  20  certificate requested) by olra.theworths.org (Postfix) with ESMTPS id\r
  21  02D7E431FAF    for <notmuch@notmuchmail.org>; Mon,  3 Sep 2012 08:36:21 -0700\r
  22  (PDT)\r
  23 Received: by eekb47 with SMTP id b47so2346482eek.26\r
  24         for <notmuch@notmuchmail.org>; Mon, 03 Sep 2012 08:36:19 -0700 (PDT)\r
  25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\r
  26  s=20120113;    h=sender:from:to:subject:in-reply-to:organization:references\r
  27         :user-agent:x-face:face:x-pgp:x-pgp-fp:date:message-id:mime-version\r
  28         :content-type; bh=u/k3i18RAV1KI9kS84iqGTaXO9KIxfONtaTiwj+h7to=;\r
  29         b=GPreNjW6g5qgjL3/k8Z7lCBSWNP/ky/rxHZdzFRFFz0MJcVlz22hbhgsoI6F1JXfC2\r
  30         oa5kIr9yOOqfq55ACAdJjxdF6gbr+bwUPpqnJfMYskRD46N2y5/C4dqv0YhW1Qxph2Xv\r
  31         bFOj509AF2A3Tj6aLpyinQEiVHVHEzMofObBuv/URDTKhsJPh9i/7inEqbtvL/7swrSr\r
  32         MRg9b9NncSlpXOINh3zvFqjWZag/sQL5ZMzxiDZMHQGgTpEFFV+NHlSHenyVY9SGXgCj\r
  33         +ulnBl+tzgm8DuED9624y0NqzpWL+I+xtgFEvUIE4AQxBEzcSpAbdoEdYHY1dISC65DX    ZPFQ==\r
  34 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
  35         d=google.com; s=20120113;\r
  36         h=sender:from:to:subject:in-reply-to:organization:references\r
  37         :user-agent:x-face:face:x-pgp:x-pgp-fp:date:message-id:mime-version\r
  38         :content-type:x-gm-message-state;\r
  39         bh=u/k3i18RAV1KI9kS84iqGTaXO9KIxfONtaTiwj+h7to=;\r
  40         b=SW1fJqPH3IRCmei69F76hczfgoL8PLeDeKiaOACY/2wkeBFCM0u9Z4cED+hYTqARw6\r
  41         /xzKn32tZA+oUjXs+sEl9ZMQVgLviLz2M0Jm+XwPv/DgumxmPTGfT+bookjOrdnUC89Z\r
  42         kK5juRen1E+F2QXV4lAeOFJnq4MBu2JwkSy7hIq1aA37FForEnaNDxAE2Mue2HN6Ppqs\r
  43         0N/59buOzHauRG1sb4zER/hkFG1PGEn5cU0lIYdHxXjYQW3ZE6uRUD6nuTennzh7oLzs\r
  44         oXnks92wPoxHeR6HN95RzLquaKZxF9N5gHy8izaD1E+QxlgtIr1e+5d5przlpu7mPMzQ\r
  45         cyPg==\r
  46 Received: by 10.14.4.201 with SMTP id 49mr22331554eej.0.1346686579375;\r
  47         Mon, 03 Sep 2012 08:36:19 -0700 (PDT)\r
  48 Received: by 10.14.4.201 with SMTP id 49mr22331541eej.0.1346686579203;\r
  49         Mon, 03 Sep 2012 08:36:19 -0700 (PDT)\r
  50 Received: from mpn-glaptop ([2620:0:105f:5:f2de:f1ff:fe35:1a72])\r
  51         by mx.google.com with ESMTPS id e7sm37527584eep.2.2012.09.03.08.36.17\r
  52         (version=TLSv1/SSLv3 cipher=OTHER);\r
  53         Mon, 03 Sep 2012 08:36:18 -0700 (PDT)\r
  54 Sender: Michal Nazarewicz <mpn@google.com>\r
  55 From: Michal Nazarewicz <mina86@mina86.com>\r
  56 To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
  57 Subject: Re: [PATCH V2 1/2] devel: add release-checks.sh\r
  58 In-Reply-To: <m2sjazdug1.fsf@guru.guru-group.fi>\r
  59 Organization: http://mina86.com/\r
  60 References: <1346491928-2356-1-git-send-email-tomi.ollila@iki.fi>\r
  61         <xa1t7gsbwbxe.fsf@mina86.com> <m2sjazdug1.fsf@guru.guru-group.fi>\r
  62 User-Agent: Notmuch/0.14+2~g416b120 (http://notmuchmail.org) Emacs/24.2.50.1\r
  63         (x86_64-unknown-linux-gnu)\r
  64 X-Face: PbkBB1w#)bOqd`iCe"Ds{e+!C7`pkC9a|f)Qo^BMQvy\q5x3?vDQJeN(DS?|-^$uMti[3D*#^_Ts"pU$jBQLq~Ud6iNwAw_r_o_4]|JO?]}P_}Nc&"p#D(ZgUb4uCNPe7~a[DbPG0T~!&c.y$Ur,=N4RT>]dNpd;        KFrfMCylc}gc??'U2j,!8%xdD\r
  65 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACQElEQVQ4jW3TMWvbQBQHcBk1xE6WyALX1069oZBMlq+ouUwpEQQ6uRjttkWP4CmBgGM0BQLBdPFZYPsyFUo6uEtKDQ7oy/U96XR2Ux8ehH/89Z6enqxBcS7Lg81jmSuujrfCZcLI/TYYvbGj+jbgFpHJ/bqQAUISj8iLyu4LuFHJTosxsucO4jSDNE0Hq3hwK/ceQ5sx97b8LcUDsILfk+ovHkOIsMbBfg43VuQ5Ln9YAGCkUdKJoXR9EclFBhixy3EGVz1K6eEkhxCAkeMMnqoAhAKwhoUJkDrCqvbecaYINlFKSRS1i12VKH1XpUd4qxL876EkMcDvHj3s5RBajHHMlA5iK32e0C7VgG0RlzFPvoYHZLRmAC0BmNcBruhkE0KsMsbEc62ZwUJDxWUdMsMhVqovoT96i/DnX/ASvz/6hbCabELLk/6FF/8PNpPCGqcZTGFcBhhAaZZDbQPaAB3+KrWWy2XgbYDNIinkdWAFcCpraDE/knwe5DBqGmgzESl1p2E4MWAz0VUPgYYzmfWb9yS4vCvgsxJriNTHoIBz5YteBvg+VGISQWUqhMiByPIPpygeDBE6elD973xWwKkEiHZAHKjhuPsFnBuArrzxtakRcISv+XMIPl4aGBUJm8Emk7qBYU8IlgNEIpiJhk/No24jHwkKTFHDWfPniR4iw5vJaw2nzSjfq2zffcE/GDjRC2dn0J0XwPAbDL84TvaFCJEU4Oml9pRyEUhR3Cl2t01AoEjRbs0sYugp14/4X5n4pU4EHHnMAAAAAElFTkSuQmCC\r
  66 X-PGP: 50751FF4\r
  67 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4\r
  68 Date: Mon, 03 Sep 2012 17:36:11 +0200\r
  69 Message-ID: <xa1tsjazunis.fsf@mina86.com>\r
  70 MIME-Version: 1.0\r
  71 Content-Type: multipart/mixed; boundary="=-=-="\r
  72 X-Gm-Message-State: ALoCoQn4zRJWSWCPibn/7y8u9mjZHKmBtE7FiZi99rDmU9HHFU12qNF5YBA8fGf8WSsv7q5VTtkwRti4mZIFG29VyjkiYZFgYT5GYRObUttOSgKa5Ch4I9YkRhBjvpZlVJveD1GDyRJlLMi9pw26zYChzlPmsxDJco/P638KHsiARjqKJ9DU3dK6VuRj/Jjv4wDoiDWWPozyL08vwgquAvUpVs1GUPQ2lg==\r
  73 X-BeenThere: notmuch@notmuchmail.org\r
  74 X-Mailman-Version: 2.1.13\r
  75 Precedence: list\r
  76 List-Id: "Use and development of the notmuch mail system."\r
  77         <notmuch.notmuchmail.org>\r
  78 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  79         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  80 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  81 List-Post: <mailto:notmuch@notmuchmail.org>\r
  82 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  83 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  84         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  85 X-List-Received-Date: Mon, 03 Sep 2012 15:36:23 -0000\r
  86 \r
  87 --=-=-=\r
  88 Content-Type: text/plain; charset=utf-8\r
  89 Content-Transfer-Encoding: quoted-printable\r
  90 \r
  91 >> Tomi Ollila <tomi.ollila@iki.fi> writes:\r
  92 >>> +for f in ./version debian/changelog NEWS "$PV_FILE"\r
  93 >>> +do\r
  94 >>> +   test -f $f || { append_emsg "File '$f' is missing"; continue; }\r
  95 >>> +   test -r $f || { append_emsg "File '$f' is unreadable"; continue; }\r
  96 >>> +   test -s $f ||   append_emsg "File '$f' is empty"\r
  97 \r
  98 > On Mon, Sep 03 2012, Michal Nazarewicz <mina86@mina86.com> wrote:\r
  99 >> if ! [ -f "$f" ]; then\r
 100 >>      append_emsg "File '$f' is missing"\r
 101 >> elif ! [ -r "$f" ]; then\r
 102 >>      append_emsg "File '$f' is unreadable"\r
 103 >> elif ! [ -s "$f" ]; then\r
 104 >>      append_emsg "File '$f' is empty"\r
 105 >> fi\r
 106 \r
 107 Tomi Ollila <tomi.ollila@iki.fi> writes:\r
 108 > IMHO this short-circuited or (||) version works well due to this\r
 109 > negation handling. The $f's should have been quoted ("$f"), though\r
 110 > (in case some of the items contain whitespace the construct=20\r
 111 > would't fail). I am open to other opinions, though.\r
 112 \r
 113 I personally don't like =E2=80=9C||=E2=80=9D or =E2=80=9C&&=E2=80=9D as a r=\r
 114 eplacement for if as I find\r
 115 it less readable.  Especially here as you use braces and =E2=80=9Ccontinue=\r
 116 =E2=80=9D.\r
 117 \r
 118 >> if [ x"$deb_notmuch" =3D xnotmuch ]\r
 119 >>\r
 120 >> And so in the rest of the conditions below.\r
 121 >\r
 122 > builtin bash '[' seems to be robust in these cases(*) ... but I'm now bre=\r
 123 aking\r
 124 > my own rule about not using most portable expressions; maybe it is just\r
 125 > ugliness of the format in so many places. I'm not changing unless there is\r
 126 > more desire for it :)\r
 127 \r
 128 It's not even bash.  Newest POSIX requires that behaviour, but I always\r
 129 use x anyway myself, hence the comment.\r
 130 \r
 131 >>> +   set x $*\r
 132 \r
 133 >> Uh?  Did you mean =E2=80=9Cset -- $*=E2=80=9D?\r
 134 \r
 135 > Nope, set in some shells don't know '--' (now I'm following the most\r
 136 > portable code snippet principle) so with 'x' and just referencing\r
 137 > positional parameters with number one larger than with '--' does the\r
 138 > trick.\r
 139 \r
 140 Interesting.  I must start doing that. :)\r
 141 \r
 142 >>> +   manthdata `sed -n '/^[.]TH NOTMUCH/ { y/"/ /; p; }' "$mp"`\r
 143 \r
 144 >> Alternatively =E2=80=9C\.=E2=80=9D instead of =E2=80=9C[.]=E2=80=9D.\r
 145 \r
 146 > I prefer [.] as a more robust alternative -- backslashes may get=20\r
 147 > "expanded away" in some cases; using [.] just frees me from checking\r
 148 > whether that may happen.\r
 149 \r
 150 I guess it's a valid point.\r
 151 \r
 152 > Thanks for the review, I'll probably send new version tomorrow...\r
 153 \r
 154 Sure thing.\r
 155 \r
 156 --=20\r
 157 Best regards,                                         _     _\r
 158 .o. | Liege of Serenely Enlightened Majesty of      o' \,=3D./ `o\r
 159 ..o | Computer Science,  Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz   =\r
 160  (o o)\r
 161 ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--\r
 162 --=-=-=\r
 163 Content-Type: multipart/signed; boundary="==-=-=";\r
 164         micalg=pgp-sha1; protocol="application/pgp-signature"\r
 165 \r
 166 --==-=-=\r
 167 Content-Type: text/plain\r
 168 \r
 169 \r
 170 --==-=-=\r
 171 Content-Type: application/pgp-signature\r
 172 \r
 173 -----BEGIN PGP SIGNATURE-----\r
 174 Version: GnuPG v1.4.10 (GNU/Linux)\r
 175 \r
 176 iQIcBAEBAgAGBQJQRM5rAAoJECBgQBJQdR/0G5sP/33VxTcHYq9fevuWAuVy7CKk\r
 177 RYaBegyKYo76qtdC8UV9RRl2vRAUn5NVeyvrD68O1y/UX2vfQ7DT7Oh1FkkOccrt\r
 178 s9ZUBWpGmuIGlJeO9uIs33ZjQGFLrk9v1c1lTC6wMHY5gkyVa/WRyDXT2jTKwfwH\r
 179 BMGHw0yafqUlFYVsI+y0rl9bP4EN9s37mtMzmqval4JGE6KSBeJMERG83Zq3MmxA\r
 180 YiB/kTViBVbf/j+t1asV+8Y82spE4KH+ErXuguyzKCEX+72hZxBaqhzgxfU2+MOe\r
 181 XZIGa30uFAtL9i1yy6QwWqSu4ajsxouHRAEuEmGPAAlncj7mdtNpwLjjTP9GmgwX\r
 182 4vSnicgRFUEscNENvhihuoJf/NE6nmtZ0D2l0+8FTCxVkVF+nN4cDqEHrwvxITpG\r
 183 vYGp1Kt6ga4wdzAezJqhph7+tzKX143RPK2NaB20184ZMjo7xd6sGfT7OH7Nprl+\r
 184 zFaJfr0ku9HD42Jvl6sPLCET2MWZYelQJjw+UDysu2pS9fImq2Z0VmJ/g9jV8WM6\r
 185 oqXKZ5cBXu00qcISGBbQl77vjEbQwGaB6LlwQOfEn+xGvE9w8UH1KU0dAtDA79Hn\r
 186 AM0eL28BqC5HrokWpkUUogOGSDEQGblzZjMPEratuTPKKi9ZZ0RqWO6htWRnJLxd\r
 187 a85JSyFasyvIn1jHMzfb\r
 188 =bon6\r
 189 -----END PGP SIGNATURE-----\r
 190 --==-=-=--\r
 191 \r
 192 --=-=-=--\r