Sender: Michal Nazarewicz <mpn@google.com>
From: Michal Nazarewicz <mina86@mina86.com>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH V2 1/2] devel: add release-checks.sh
In-Reply-To: <m2sjazdug1.fsf@guru.guru-group.fi>
Organization: http://mina86.com/
References: <1346491928-2356-1-git-send-email-tomi.ollila@iki.fi>
	<xa1t7gsbwbxe.fsf@mina86.com> <m2sjazdug1.fsf@guru.guru-group.fi>
User-Agent: Notmuch/0.14+2~g416b120 (http://notmuchmail.org) Emacs/24.2.50.1
	(x86_64-unknown-linux-gnu)
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACQElEQVQ4jW3TMWvbQBQHcBk1xE6WyALX1069oZBMlq+ouUwpEQQ6uRjttkWP4CmBgGM0BQLBdPFZYPsyFUo6uEtKDQ7oy/U96XR2Ux8ehH/89Z6enqxBcS7Lg81jmSuujrfCZcLI/TYYvbGj+jbgFpHJ/bqQAUISj8iLyu4LuFHJTosxsucO4jSDNE0Hq3hwK/ceQ5sx97b8LcUDsILfk+ovHkOIsMbBfg43VuQ5Ln9YAGCkUdKJoXR9EclFBhixy3EGVz1K6eEkhxCAkeMMnqoAhAKwhoUJkDrCqvbecaYINlFKSRS1i12VKH1XpUd4qxL876EkMcDvHj3s5RBajHHMlA5iK32e0C7VgG0RlzFPvoYHZLRmAC0BmNcBruhkE0KsMsbEc62ZwUJDxWUdMsMhVqovoT96i/DnX/ASvz/6hbCabELLk/6FF/8PNpPCGqcZTGFcBhhAaZZDbQPaAB3+KrWWy2XgbYDNIinkdWAFcCpraDE/knwe5DBqGmgzESl1p2E4MWAz0VUPgYYzmfWb9yS4vCvgsxJriNTHoIBz5YteBvg+VGISQWUqhMiByPIPpygeDBE6elD973xWwKkEiHZAHKjhuPsFnBuArrzxtakRcISv+XMIPl4aGBUJm8Emk7qBYU8IlgNEIpiJhk/No24jHwkKTFHDWfPniR4iw5vJaw2nzSjfq2zffcE/GDjRC2dn0J0XwPAbDL84TvaFCJEU4Oml9pRyEUhR3Cl2t01AoEjRbs0sYugp14/4X5n4pU4EHHnMAAAAAElFTkSuQmCC
Date: Mon, 03 Sep 2012 17:36:11 +0200
Message-ID: <xa1tsjazunis.fsf@mina86.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Precedence: list

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

>> Tomi Ollila <tomi.ollila@iki.fi> writes:
>>> +for f in ./version debian/changelog NEWS "$PV_FILE"
>>> +do
>>> +	test -f $f || { append_emsg "File '$f' is missing"; continue; }
>>> +	test -r $f || { append_emsg "File '$f' is unreadable"; continue; }
>>> +	test -s $f ||   append_emsg "File '$f' is empty"

> On Mon, Sep 03 2012, Michal Nazarewicz <mina86@mina86.com> wrote:
>> if ! [ -f "$f" ]; then
>> 	append_emsg "File '$f' is missing"
>> elif ! [ -r "$f" ]; then
>> 	append_emsg "File '$f' is unreadable"
>> elif ! [ -s "$f" ]; then
>> 	append_emsg "File '$f' is empty"
>> fi

Tomi Ollila <tomi.ollila@iki.fi> writes:
> IMHO this short-circuited or (||) version works well due to this
> negation handling. The $f's should have been quoted ("$f"), though
> (in case some of the items contain whitespace the construct=20
> would't fail). I am open to other opinions, though.

I personally don't like =E2=80=9C||=E2=80=9D or =E2=80=9C&&=E2=80=9D as a r=
eplacement for if as I find
it less readable.  Especially here as you use braces and =E2=80=9Ccontinue=
=E2=80=9D.

>> if [ x"$deb_notmuch" =3D xnotmuch ]
>>
>> And so in the rest of the conditions below.
>
> builtin bash '[' seems to be robust in these cases(*) ... but I'm now bre=
aking
> my own rule about not using most portable expressions; maybe it is just
> ugliness of the format in so many places. I'm not changing unless there is
> more desire for it :)

It's not even bash.  Newest POSIX requires that behaviour, but I always
use x anyway myself, hence the comment.

>>> +	set x $*

>> Uh?  Did you mean =E2=80=9Cset -- $*=E2=80=9D?

> Nope, set in some shells don't know '--' (now I'm following the most
> portable code snippet principle) so with 'x' and just referencing
> positional parameters with number one larger than with '--' does the
> trick.

Interesting.  I must start doing that. :)

>>> +	manthdata `sed -n '/^[.]TH NOTMUCH/ { y/"/ /; p; }' "$mp"`

>> Alternatively =E2=80=9C\.=E2=80=9D instead of =E2=80=9C[.]=E2=80=9D.

> I prefer [.] as a more robust alternative -- backslashes may get=20
> "expanded away" in some cases; using [.] just frees me from checking
> whether that may happen.

I guess it's a valid point.

> Thanks for the review, I'll probably send new version tomorrow...

Sure thing.

--=20
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=3D./ `o
..o | Computer Science,  Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz   =
 (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--
--=-=-=
Content-Type: multipart/signed; boundary="==-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"

--==-=-=
Content-Type: text/plain


--==-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAEBAgAGBQJQRM5rAAoJECBgQBJQdR/0G5sP/33VxTcHYq9fevuWAuVy7CKk
RYaBegyKYo76qtdC8UV9RRl2vRAUn5NVeyvrD68O1y/UX2vfQ7DT7Oh1FkkOccrt
s9ZUBWpGmuIGlJeO9uIs33ZjQGFLrk9v1c1lTC6wMHY5gkyVa/WRyDXT2jTKwfwH
BMGHw0yafqUlFYVsI+y0rl9bP4EN9s37mtMzmqval4JGE6KSBeJMERG83Zq3MmxA
YiB/kTViBVbf/j+t1asV+8Y82spE4KH+ErXuguyzKCEX+72hZxBaqhzgxfU2+MOe
XZIGa30uFAtL9i1yy6QwWqSu4ajsxouHRAEuEmGPAAlncj7mdtNpwLjjTP9GmgwX
4vSnicgRFUEscNENvhihuoJf/NE6nmtZ0D2l0+8FTCxVkVF+nN4cDqEHrwvxITpG
vYGp1Kt6ga4wdzAezJqhph7+tzKX143RPK2NaB20184ZMjo7xd6sGfT7OH7Nprl+
zFaJfr0ku9HD42Jvl6sPLCET2MWZYelQJjw+UDysu2pS9fImq2Z0VmJ/g9jV8WM6
oqXKZ5cBXu00qcISGBbQl77vjEbQwGaB6LlwQOfEn+xGvE9w8UH1KU0dAtDA79Hn
AM0eL28BqC5HrokWpkUUogOGSDEQGblzZjMPEratuTPKKi9ZZ0RqWO6htWRnJLxd
a85JSyFasyvIn1jHMzfb
=bon6
-----END PGP SIGNATURE-----
--==-=-=--

--=-=-=--