a9/4b53822182a084dbdba6fcfedc38737bf39534

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 1479A431FC0\r
   6         for <notmuch@notmuchmail.org>; Tue,  7 Aug 2012 11:26:41 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id Tn3c-49hEVwT for <notmuch@notmuchmail.org>;\r
  16         Tue,  7 Aug 2012 11:26:40 -0700 (PDT)\r
  17 Received: from dmz-mailsec-scanner-7.mit.edu (DMZ-MAILSEC-SCANNER-7.MIT.EDU\r
  18         [18.7.68.36])\r
  19         by olra.theworths.org (Postfix) with ESMTP id 91FC0431FAF\r
  20         for <notmuch@notmuchmail.org>; Tue,  7 Aug 2012 11:26:40 -0700 (PDT)\r
  21 X-AuditID: 12074424-b7fa06d0000008c2-ec-50215ddfb3a1\r
  22 Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
  23         by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id 85.31.02242.FDD51205; Tue,  7 Aug 2012 14:26:39 -0400 (EDT)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q77IQcjX031950; \r
  27         Tue, 7 Aug 2012 14:26:39 -0400\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q77IQbjC000088\r
  32         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
  33         Tue, 7 Aug 2012 14:26:38 -0400 (EDT)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1SyoUH-0003IK-9i; Tue, 07 Aug 2012 14:26:37 -0400\r
  37 From: Austin Clements <amdragon@MIT.EDU>\r
  38 To: Mark Walters <markwalters1009@gmail.com>\r
  39 Subject: Re: [PATCH v2] emacs: notmuch search bugfix\r
  40 In-Reply-To: <877gta1x4d.fsf@qmul.ac.uk>\r
  41 References: <87boinpqfg.fsf@qmul.ac.uk> <20120806234732.GM22601@mit.edu>\r
  42         <87pq72bthc.fsf@qmul.ac.uk> <20120807160352.GA2811@mit.edu>\r
  43         <877gta1x4d.fsf@qmul.ac.uk>\r
  44 User-Agent: Notmuch/0.13.2+131~g3e2f67b (http://notmuchmail.org) Emacs/23.3.1\r
  45         (i486-pc-linux-gnu)\r
  46 Date: Tue, 07 Aug 2012 14:26:37 -0400\r
  47 Message-ID: <87lihqtv6q.fsf@awakening.csail.mit.edu>\r
  48 MIME-Version: 1.0\r
  49 Content-Type: text/plain; charset=us-ascii\r
  50 X-Brightmail-Tracker:\r
  51  H4sIAAAAAAAAA+NgFnrDIsWRmVeSWpSXmKPExsUixCmqrXs/VjHAYMoNUYvVc3ksrt+cyezA\r
  52         5LFz1l12j2erbjEHMEVx2aSk5mSWpRbp2yVwZRxYdIu94BtbxeVTUxkbGK+xdjFycEgImEg8\r
  53         blPrYuQEMsUkLtxbz9bFyMUhJLCPUWLZojmMEM56RokPD++yQDgnmCTWLr3PDOEsYZQ4dXAR\r
  54         G0g/m4CGxLb9yxlBbBEBHYnbhxawg9jMAtIS3343M4GsEwZat2qjHkiYE6h8z8y/UOsWAG34\r
  55         dg5sjqhAosT9VX9YQWwWAVWJX9OXgcV5gXoPf1/MCGELSpyc+YQFYr6WxI1/L5kmMArOQpKa\r
  56         hSS1gJFpFaNsSm6Vbm5iZk5xarJucXJiXl5qka65Xm5miV5qSukmRlCgsruo7GBsPqR0iFGA\r
  57         g1GJh/cCl0KAEGtiWXFl7iFGSQ4mJVHeAFfFACG+pPyUyozE4oz4otKc1OJDjBIczEoivId3\r
  58         ApXzpiRWVqUW5cOkpDlYlMR5r6fc9BcSSE8sSc1OTS1ILYLJynBwKEnwnvIEGipYlJqeWpGW\r
  59         mVOCkGbi4AQZzgM0/AxIDW9xQWJucWY6RP4Uo6KUOO9JkIQASCKjNA+uF5ZIXjGKA70izPsA\r
  60         pIoHmITgul8BDWYCGuwtLwcyuCQRISXVwFgbJVqRvjiKu3+v1M+tzffzpmj4T90uLR6m9//1\r
  61         A5nHn39MWhG3iSlYZK+TkKyFoOqTZRH1sxs3cCwpibtvafrxjOA8pbP/tiqs/pO/J6+N44b/\r
  62         f92DqQLH6/6H7hLT9jr1pf7uHllRI8HcGQnHnzaIGp56r+2qerHHfJFam+fenGWioiHpU5RY\r
  63         ijMSDbWYi4oTAZEeNFr/AgAA\r
  64 Cc: notmuch@notmuchmail.org\r
  65 X-BeenThere: notmuch@notmuchmail.org\r
  66 X-Mailman-Version: 2.1.13\r
  67 Precedence: list\r
  68 List-Id: "Use and development of the notmuch mail system."\r
  69         <notmuch.notmuchmail.org>\r
  70 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  71         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  72 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  73 List-Post: <mailto:notmuch@notmuchmail.org>\r
  74 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  75 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  76         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  77 X-List-Received-Date: Tue, 07 Aug 2012 18:26:41 -0000\r
  78 \r
  79 On Tue, 07 Aug 2012, Mark Walters <markwalters1009@gmail.com> wrote:\r
  80 > The recent change to use json for notmuch-search.el introduced a bug\r
  81 > in the code for keeping position on refresh. The problem is a\r
  82 > comparison between (plist-get result :thread) and a thread-id returned\r
  83 > by notmuch-search-find-thread-id: the latter is prefixed with\r
  84 > "thread:"\r
  85 >\r
  86 > We fix this by adding an option to notmuch-search-find-thread-id to\r
  87 > return the bare thread-id. It appears that notmuch-search-refresh-view\r
  88 > is the only caller of notmuch-search that supplies a thread-id so this\r
  89 > change should be safe (but could theoretically break users .emacs\r
  90 > functions).\r
  91 > ---\r
  92 >\r
  93 > I think this implements all of Austin's suggestions, and it adds a short\r
  94 > remark to NEWS (since in unlikely cases it could break users' functions)\r
  95 > and updates the docstring for notmuch-search. \r
  96 \r
  97 LGTM.\r