From: Austin Clements <amdragon@MIT.EDU>
To: Mark Walters <markwalters1009@gmail.com>
Subject: Re: [PATCH v2] emacs: notmuch search bugfix
In-Reply-To: <877gta1x4d.fsf@qmul.ac.uk>
References: <87boinpqfg.fsf@qmul.ac.uk> <20120806234732.GM22601@mit.edu>
	<87pq72bthc.fsf@qmul.ac.uk> <20120807160352.GA2811@mit.edu>
	<877gta1x4d.fsf@qmul.ac.uk>
User-Agent: Notmuch/0.13.2+131~g3e2f67b (http://notmuchmail.org) Emacs/23.3.1
	(i486-pc-linux-gnu)
Date: Tue, 07 Aug 2012 14:26:37 -0400
Message-ID: <87lihqtv6q.fsf@awakening.csail.mit.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: notmuch@notmuchmail.org
Precedence: list

On Tue, 07 Aug 2012, Mark Walters <markwalters1009@gmail.com> wrote:
> The recent change to use json for notmuch-search.el introduced a bug
> in the code for keeping position on refresh. The problem is a
> comparison between (plist-get result :thread) and a thread-id returned
> by notmuch-search-find-thread-id: the latter is prefixed with
> "thread:"
>
> We fix this by adding an option to notmuch-search-find-thread-id to
> return the bare thread-id. It appears that notmuch-search-refresh-view
> is the only caller of notmuch-search that supplies a thread-id so this
> change should be safe (but could theoretically break users .emacs
> functions).
> ---
>
> I think this implements all of Austin's suggestions, and it adds a short
> remark to NEWS (since in unlikely cases it could break users' functions)
> and updates the docstring for notmuch-search. 

LGTM.