1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 1B093431FBF
\r
6 for <notmuch@notmuchmail.org>; Tue, 28 Jan 2014 03:13:26 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id slIproWt2nqB for <notmuch@notmuchmail.org>;
\r
16 Tue, 28 Jan 2014 03:13:16 -0800 (PST)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 7EB15431FBD
\r
19 for <notmuch@notmuchmail.org>; Tue, 28 Jan 2014 03:13:16 -0800 (PST)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 9BD52100051;
\r
22 Tue, 28 Jan 2014 13:13:06 +0200 (EET)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH v3] build: write VERSION file containing $(VERSION) string
\r
26 In-Reply-To: <87zjmgkgxm.fsf@zancas.localnet>
\r
27 References: <1390858998-9846-1-git-send-email-tomi.ollila@iki.fi>
\r
28 <1390859290-10112-1-git-send-email-tomi.ollila@iki.fi>
\r
29 <87zjmgkgxm.fsf@zancas.localnet>
\r
30 User-Agent: Notmuch/0.17+55~g4397960 (http://notmuchmail.org) Emacs/24.3.1
\r
31 (x86_64-unknown-linux-gnu)
\r
32 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
33 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
34 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
35 Date: Tue, 28 Jan 2014 13:13:06 +0200
\r
36 Message-ID: <m261p4mkal.fsf@guru.guru-group.fi>
\r
38 Content-Type: text/plain
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.13
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Tue, 28 Jan 2014 11:13:26 -0000
\r
53 On Tue, Jan 28 2014, David Bremner <david@tethera.net> wrote:
\r
55 > Tomi Ollila <tomi.ollila@iki.fi> writes:
\r
57 >> +VERSION:=$(shell gv=`exec git describe --match '[0-9.]*'|sed -e s/_/~/ -e s/-/+/ -e s/-/~/`; test -f VERSION || touch VERSION; read fv < VERSION; test x"$$fv" = x"$$gv" || echo "$$gv" > VERSION; echo "$$gv")
\r
59 > does this need to be one line long? It's a bit scary.
\r
61 Probably not -- I realized after sending v3 I could have split that
\r
62 (among one other problem...)
\r
65 >> +# this file may already have been updated.
\r
66 >> +VERSION: version
\r
67 >> + echo $(VERSION) > version
\r
69 > I'd prefer the build process does not change any version controlled
\r
70 > file. It should be source, or generated, but not both. did you mean to
\r
71 > write to VERSION here?
\r
73 I sure meant to. actually echo $(VERSION) > $@
\r
79 Tnx for the review...
\r