1 Return-Path: <nelhage@ksplice.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 78C6A4196F4
\r
6 for <notmuch@notmuchmail.org>; Thu, 13 May 2010 20:34:49 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5
\r
12 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=ham
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id h4KI7L2O9EQv for <notmuch@notmuchmail.org>;
\r
16 Thu, 13 May 2010 20:34:39 -0700 (PDT)
\r
17 Received: from mail-qy0-f184.google.com (mail-qy0-f184.google.com
\r
19 by olra.theworths.org (Postfix) with ESMTP id EFEDE4196F0
\r
20 for <notmuch@notmuchmail.org>; Thu, 13 May 2010 20:34:38 -0700 (PDT)
\r
21 Received: by qyk14 with SMTP id 14so33043qyk.26
\r
22 for <notmuch@notmuchmail.org>; Thu, 13 May 2010 20:34:38 -0700 (PDT)
\r
23 Received: by 10.224.94.83 with SMTP id y19mr245461qam.71.1273808078233;
\r
24 Thu, 13 May 2010 20:34:38 -0700 (PDT)
\r
25 Received: from PHANATIQUE.MIT.EDU (c-71-192-160-118.hsd1.nh.comcast.net
\r
27 by mx.google.com with ESMTPS id 22sm1207252qyk.2.2010.05.13.20.34.35
\r
28 (version=TLSv1/SSLv3 cipher=RC4-MD5);
\r
29 Thu, 13 May 2010 20:34:36 -0700 (PDT)
\r
30 Date: Thu, 13 May 2010 23:34:34 -0400
\r
31 From: Nelson Elhage <nelhage@ksplice.com>
\r
32 To: sebastian@sspaeth.de
\r
33 Subject: Re: [PATCH] emacs: notmuch-hello: Use our own keymap.
\r
34 Message-ID: <20100514033434.GA5072@ksplice.com>
\r
35 References: <1273805175-6660-1-git-send-email-nelhage@ksplice.com>
\r
36 <774b5d59b19663f41b4a427c1622f045.squirrel@webmail.sspaeth.de>
\r
38 Content-Type: text/plain; charset=us-ascii
\r
39 Content-Disposition: inline
\r
40 In-Reply-To: <774b5d59b19663f41b4a427c1622f045.squirrel@webmail.sspaeth.de>
\r
41 User-Agent: Mutt/1.5.20 (2009-06-14)
\r
42 Cc: notmuch@notmuchmail.org
\r
43 X-BeenThere: notmuch@notmuchmail.org
\r
44 X-Mailman-Version: 2.1.13
\r
46 List-Id: "Use and development of the notmuch mail system."
\r
47 <notmuch.notmuchmail.org>
\r
48 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
50 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
51 List-Post: <mailto:notmuch@notmuchmail.org>
\r
52 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
53 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
54 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
55 X-List-Received-Date: Fri, 14 May 2010 03:34:49 -0000
\r
57 On Thu, May 13, 2010 at 07:58:38PM -0700, sebastian@sspaeth.de wrote:
\r
58 > > Previously, we were adding our bindings directly to `widget-keymap',
\r
59 > > resulting in them being shared by anything else that used that keymap.
\r
61 > Is this patch preferable over the one I sent some time ago in
\r
62 > id:1272882573-9864-1-git-send-email-Sebastian@SSpaeth.de ?
\r
64 > My patch makes notmuch-hello a major mode and also creates the proper
\r
65 > keymap. THe major mode allows the '?' keybinding to also work.
\r
68 Ah, I failed to properly search the mail archives before sending
\r
69 this. Your patch looks preferable with one exception: I think that
\r
70 making widget-keymap a parent of notmuch-hello-mode-map is probably
\r
71 better than just copying widget-keymap -- if someone defines
\r
72 additional bindings in widget-keymap, we should inherit them whether
\r
73 they are defined before or after notmuch-hello is loaded. (This is
\r
74 also recommended by the documentation for `widget-keymap').
\r