Date: Thu, 13 May 2010 23:34:34 -0400
From: Nelson Elhage <nelhage@ksplice.com>
To: sebastian@sspaeth.de
Subject: Re: [PATCH] emacs: notmuch-hello: Use our own keymap.
Message-ID: <20100514033434.GA5072@ksplice.com>
References: <1273805175-6660-1-git-send-email-nelhage@ksplice.com>
	<774b5d59b19663f41b4a427c1622f045.squirrel@webmail.sspaeth.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <774b5d59b19663f41b4a427c1622f045.squirrel@webmail.sspaeth.de>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: notmuch@notmuchmail.org
Precedence: list

On Thu, May 13, 2010 at 07:58:38PM -0700, sebastian@sspaeth.de wrote:
> > Previously, we were adding our bindings directly to `widget-keymap',
> > resulting in them being shared by anything else that used that keymap.
> 
> Is this patch preferable over the one I sent some time ago in
> id:1272882573-9864-1-git-send-email-Sebastian@SSpaeth.de ?
> 
> My patch makes notmuch-hello a major mode and also creates the proper
> keymap. THe major mode allows the '?' keybinding to also work.
> 

Ah, I failed to properly search the mail archives before sending
this. Your patch looks preferable with one exception: I think that
making widget-keymap a parent of notmuch-hello-mode-map is probably
better than just copying widget-keymap -- if someone defines
additional bindings in widget-keymap, we should inherit them whether
they are defined before or after notmuch-hello is loaded. (This is
also recommended by the documentation for `widget-keymap').

- Nelson