1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 5A317431FAF
\r
6 for <notmuch@notmuchmail.org>; Mon, 16 Sep 2013 13:31:41 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id sgHx58zvgFEu for <notmuch@notmuchmail.org>;
\r
16 Mon, 16 Sep 2013 13:31:33 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 985F3431FAE
\r
19 for <notmuch@notmuchmail.org>; Mon, 16 Sep 2013 13:31:33 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id E1FB61000B2;
\r
22 Mon, 16 Sep 2013 23:31:25 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH 0/3] Use global keymap for pick entry.
\r
26 In-Reply-To: <1379255706-2418-1-git-send-email-markwalters1009@gmail.com>
\r
27 References: <1379255706-2418-1-git-send-email-markwalters1009@gmail.com>
\r
28 User-Agent: Notmuch/0.16+86~g2d126a3 (http://notmuchmail.org) Emacs/24.3.1
\r
29 (x86_64-unknown-linux-gnu)
\r
30 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
31 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
32 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
33 Date: Mon, 16 Sep 2013 23:31:25 +0300
\r
34 Message-ID: <m2vc20cxuq.fsf@guru.guru-group.fi>
\r
36 Content-Type: text/plain
\r
37 X-BeenThere: notmuch@notmuchmail.org
\r
38 X-Mailman-Version: 2.1.13
\r
40 List-Id: "Use and development of the notmuch mail system."
\r
41 <notmuch.notmuchmail.org>
\r
42 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
43 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
44 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
45 List-Post: <mailto:notmuch@notmuchmail.org>
\r
46 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
47 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
49 X-List-Received-Date: Mon, 16 Sep 2013 20:31:41 -0000
\r
51 On Sun, Sep 15 2013, Mark Walters <markwalters1009@gmail.com> wrote:
\r
53 > This uses the recently added global keymap for pick entry. Adding this
\r
54 > showed a couple of historical anomalies: first that we don't need to
\r
55 > quote the keymap in define-key, and secondly that the
\r
56 > notmuch-pick-from-hello function is no longer needed.
\r
58 > Thus we remove the superfluous quotes and we remove the unneeded
\r
61 > All tests pass and all key bindings still seem to work.
\r
63 This series LGTM. I don't fully understand this (fset 'kmap kmap)
\r
64 business but everywhere I looked (define-key uses the non-symbol-reference
\r
65 to the keymap (were there fsets or not))
\r
78 > contrib: pick: remove some superfluous quotes
\r
79 > contrib: pick: use the new notmuch-common-keymap for pick entry
\r
80 > contrib: pick: remove unused notmuch-pick-from-hello
\r
82 > contrib/notmuch-pick/notmuch-pick.el | 21 ++++-----------------
\r
83 > 1 files changed, 4 insertions(+), 17 deletions(-)
\r
88 > _______________________________________________
\r
89 > notmuch mailing list
\r
90 > notmuch@notmuchmail.org
\r
91 > http://notmuchmail.org/mailman/listinfo/notmuch
\r