Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 5A317431FAF for ; Mon, 16 Sep 2013 13:31:41 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sgHx58zvgFEu for ; Mon, 16 Sep 2013 13:31:33 -0700 (PDT) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by olra.theworths.org (Postfix) with ESMTP id 985F3431FAE for ; Mon, 16 Sep 2013 13:31:33 -0700 (PDT) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id E1FB61000B2; Mon, 16 Sep 2013 23:31:25 +0300 (EEST) From: Tomi Ollila To: Mark Walters , notmuch@notmuchmail.org Subject: Re: [PATCH 0/3] Use global keymap for pick entry. In-Reply-To: <1379255706-2418-1-git-send-email-markwalters1009@gmail.com> References: <1379255706-2418-1-git-send-email-markwalters1009@gmail.com> User-Agent: Notmuch/0.16+86~g2d126a3 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Sep 2013 20:31:41 -0000 On Sun, Sep 15 2013, Mark Walters wrote: > This uses the recently added global keymap for pick entry. Adding this > showed a couple of historical anomalies: first that we don't need to > quote the keymap in define-key, and secondly that the > notmuch-pick-from-hello function is no longer needed. > > Thus we remove the superfluous quotes and we remove the unneeded > function. > > All tests pass and all key bindings still seem to work. This series LGTM. I don't fully understand this (fset 'kmap kmap) business but everywhere I looked (define-key uses the non-symbol-reference to the keymap (were there fsets or not)) > > Best wishes > > Mark Tomi > > > Mark Walters (3): > contrib: pick: remove some superfluous quotes > contrib: pick: use the new notmuch-common-keymap for pick entry > contrib: pick: remove unused notmuch-pick-from-hello > > contrib/notmuch-pick/notmuch-pick.el | 21 ++++----------------- > 1 files changed, 4 insertions(+), 17 deletions(-) > > -- > 1.7.9.1 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch