1 Return-Path: <teythoon@jade-hamburg.de>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id 9CA646DE01F7
\r
6 for <notmuch@notmuchmail.org>; Tue, 1 Mar 2016 08:46:24 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=0.001 tagged_above=-999 required=5
\r
12 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001,
\r
13 RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled
\r
14 Received: from arlo.cworth.org ([127.0.0.1])
\r
15 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id B8nNiF5T5Lf0 for <notmuch@notmuchmail.org>;
\r
17 Tue, 1 Mar 2016 08:46:22 -0800 (PST)
\r
18 Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68])
\r
19 by arlo.cworth.org (Postfix) with ESMTPS id 6E5736DE00DF
\r
20 for <notmuch@notmuchmail.org>; Tue, 1 Mar 2016 08:46:22 -0800 (PST)
\r
21 Received: from thinkbox (p4FD27A8D.dip0.t-ipconnect.de [79.210.122.141])
\r
22 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
\r
23 (No client certificate requested)
\r
24 by mail.cryptobitch.de (Postfix) with ESMTPSA id 0A83D8F94ED;
\r
25 Tue, 1 Mar 2016 17:46:19 +0100 (CET)
\r
26 Received: from teythoon by thinkbox with local (Exim 4.84)
\r
27 (envelope-from <teythoon@thinkbox.jade-hamburg.de>)
\r
28 id 1aanRC-0006ce-5o; Tue, 01 Mar 2016 17:46:18 +0100
\r
29 Content-Type: text/plain; charset="utf-8"
\r
31 Content-Transfer-Encoding: quoted-printable
\r
32 To: Jani Nikula <jani@nikula.org>, "Tomi Ollila" <tomi.ollila@iki.fi>,
\r
33 notmuch@notmuchmail.org
\r
34 From: Justus Winter <4winter@informatik.uni-hamburg.de>
\r
35 In-Reply-To: <87k2nxh3pn.fsf@nikula.org>
\r
36 Cc: tomi.ollila@iki.fi
\r
37 References: <1439303834-27030-1-git-send-email-tomi.ollila@iki.fi>
\r
38 <87k2nxh3pn.fsf@nikula.org>
\r
39 Message-ID: <20160301164618.4486.11370@thinkbox.jade-hamburg.de>
\r
40 User-Agent: alot/0.3.8.dev
\r
41 Subject: Re: [PATCH] lib: have two definitions of NOTMUCH_DEPRECATED macro
\r
42 Date: Tue, 01 Mar 2016 17:46:18 +0100
\r
43 X-BeenThere: notmuch@notmuchmail.org
\r
44 X-Mailman-Version: 2.1.20
\r
46 List-Id: "Use and development of the notmuch mail system."
\r
47 <notmuch.notmuchmail.org>
\r
48 List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
50 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
51 List-Post: <mailto:notmuch@notmuchmail.org>
\r
52 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
53 List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
\r
54 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
55 X-List-Received-Date: Tue, 01 Mar 2016 16:46:24 -0000
\r
57 Quoting Jani Nikula (2015-12-29 12:52:20)
\r
58 > > __has_extension() replacement was modeled after __has_attribute()
\r
59 > > definition in compat/function-attributes.h. Thanks Justus.
\r
61 Hum, I didn't even recall doing that.
\r
63 > > +/* clang provides this macro to test for support for language
\r
64 > > + * extensions. If it isn't defined, this provides a compatibility
\r
65 > > + * macro for other compilers.
\r
67 > > +#ifndef __has_extension
\r
68 > > +#define __has_extension(x) 0
\r
72 > This file is included by the users of the library, and thus this
\r
73 > definition leaks to our users. It might cause problems if the users have
\r
74 > different expectations for handling ifndef __has_extension. I don't
\r
75 > think we should define things outside of our namespace in notmuch.h.
\r
77 Indeed, even more so since the __ namespace is reserved. But that
\r
78 should be easy to fix, right? Simply pick a less problematic name for
\r
81 I'd love to see this issue fixed.
\r