Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
To: Jani Nikula <jani@nikula.org>, "Tomi Ollila" <tomi.ollila@iki.fi>,
 notmuch@notmuchmail.org
From: Justus Winter <4winter@informatik.uni-hamburg.de>
In-Reply-To: <87k2nxh3pn.fsf@nikula.org>
Cc: tomi.ollila@iki.fi
References: <1439303834-27030-1-git-send-email-tomi.ollila@iki.fi>
 <87k2nxh3pn.fsf@nikula.org>
Message-ID: <20160301164618.4486.11370@thinkbox.jade-hamburg.de>
User-Agent: alot/0.3.8.dev
Subject: Re: [PATCH] lib: have two definitions of NOTMUCH_DEPRECATED macro
Date: Tue, 01 Mar 2016 17:46:18 +0100
Precedence: list

Quoting Jani Nikula (2015-12-29 12:52:20)
> > __has_extension() replacement was modeled after __has_attribute()
> > definition in compat/function-attributes.h. Thanks Justus.

Hum, I didn't even recall doing that.

> > +/* clang provides this macro to test for support for language
> > + * extensions. If it isn't defined, this provides a compatibility
> > + * macro for other compilers.
> > + */
> > +#ifndef __has_extension
> > +#define __has_extension(x) 0
> > +#endif
> =

> This file is included by the users of the library, and thus this
> definition leaks to our users. It might cause problems if the users have
> different expectations for handling ifndef __has_extension. I don't
> think we should define things outside of our namespace in notmuch.h.

Indeed, even more so since the __ namespace is reserved.  But that
should be easy to fix, right?  Simply pick a less problematic name for
the new macro.

I'd love to see this issue fixed.

Cheers,
Justus