1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 1E9EB431FC7
\r
6 for <notmuch@notmuchmail.org>; Thu, 30 Oct 2014 01:53:11 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id O8M4nRfoqhYj for <notmuch@notmuchmail.org>;
\r
16 Thu, 30 Oct 2014 01:53:03 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 68B5C431FB6
\r
19 for <notmuch@notmuchmail.org>; Thu, 30 Oct 2014 01:53:03 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 548E4100051;
\r
22 Thu, 30 Oct 2014 10:52:43 +0200 (EET)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Mark Walters <markwalters1009@gmail.com>,
\r
25 Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
\r
26 Subject: Re: [PATCH v4 5/6] cli: search: Add configurable way to
\r
27 filter out duplicate addresses
\r
28 In-Reply-To: <87egtqug4t.fsf@qmul.ac.uk>
\r
29 References: <1414421455-3037-1-git-send-email-sojkam1@fel.cvut.cz>
\r
30 <1414421455-3037-6-git-send-email-sojkam1@fel.cvut.cz>
\r
31 <87egtqug4t.fsf@qmul.ac.uk>
\r
32 User-Agent: Notmuch/0.18.1+130~ga61922f (http://notmuchmail.org) Emacs/24.3.1
\r
33 (x86_64-unknown-linux-gnu)
\r
34 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
35 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
36 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
37 Date: Thu, 30 Oct 2014 10:52:43 +0200
\r
38 Message-ID: <m2zjceueg4.fsf@guru.guru-group.fi>
\r
40 Content-Type: text/plain
\r
41 X-BeenThere: notmuch@notmuchmail.org
\r
42 X-Mailman-Version: 2.1.13
\r
44 List-Id: "Use and development of the notmuch mail system."
\r
45 <notmuch.notmuchmail.org>
\r
46 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
47 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
48 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
49 List-Post: <mailto:notmuch@notmuchmail.org>
\r
50 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
51 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
52 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
53 X-List-Received-Date: Thu, 30 Oct 2014 08:53:11 -0000
\r
55 On Thu, Oct 30 2014, Mark Walters <markwalters1009@gmail.com> wrote:
\r
57 > On Mon, 27 Oct 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
\r
58 >> This adds an algorithm to filter out duplicate addresses from address
\r
59 >> outputs (sender, receivers). The algorithm can be configured with
\r
60 >> --filter-by command line option.
\r
62 >> The code here is an extended version of a patch from Jani Nikula.
\r
66 > As this is getting into the more controversial bike shedding region I
\r
67 > wonder if it would be worth splitting this into 2 patches: the first
\r
68 > could do the default dedupe based on name/address and the second could
\r
69 > do add the filter-by options.
\r
71 > I think the default deduping is obviously worth doing but I am not sure
\r
72 > about the rest. In any case I think the default deduping could go in
\r
73 > pre-freeze but I would recommend the rest is left until after.
\r
75 I can agree with that, but there is one hard thing to resolve:
\r
78 (*) http://martinfowler.com/bliki/TwoHardThings.html
\r
80 With all rest ignored (sorry no time to work on this in more detail now),
\r
81 this default deduping could be done with single argument '--unique'...
\r