From: Tomi Ollila <tomi.ollila@iki.fi>
To: Mark Walters <markwalters1009@gmail.com>,
	Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
Subject: Re: [PATCH v4 5/6] cli: search: Add configurable way to
	filter	out	duplicate addresses
In-Reply-To: <87egtqug4t.fsf@qmul.ac.uk>
References: <1414421455-3037-1-git-send-email-sojkam1@fel.cvut.cz>
	<1414421455-3037-6-git-send-email-sojkam1@fel.cvut.cz>
	<87egtqug4t.fsf@qmul.ac.uk>
User-Agent: Notmuch/0.18.1+130~ga61922f (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
Date: Thu, 30 Oct 2014 10:52:43 +0200
Message-ID: <m2zjceueg4.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Thu, Oct 30 2014, Mark Walters <markwalters1009@gmail.com> wrote:

> On Mon, 27 Oct 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
>> This adds an algorithm to filter out duplicate addresses from address
>> outputs (sender, receivers). The algorithm can be configured with
>> --filter-by command line option.
>>
>> The code here is an extended version of a patch from Jani Nikula.
>
> Hi
>
> As this is getting into the more controversial bike shedding region I
> wonder if it would be worth splitting this into 2 patches: the first
> could do the default dedupe based on name/address and the second could
> do add the filter-by options. 
>
> I think the default deduping is obviously worth doing but I am not sure
> about the rest. In any case I think the default deduping could go in
> pre-freeze but I would recommend the rest is left until after.

I can agree with that, but there is one hard thing to resolve: 
"naming things"(*)

(*) http://martinfowler.com/bliki/TwoHardThings.html

With all rest ignored (sorry no time to work on this in more detail now),
this default deduping could be done with single argument '--unique'...

Tomi