1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 1B6A8431FB6
\r
6 for <notmuch@notmuchmail.org>; Wed, 4 Jul 2012 09:31:48 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id xlJIMFzm9tye for <notmuch@notmuchmail.org>;
\r
16 Wed, 4 Jul 2012 09:31:47 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 68AF7431FAE
\r
19 for <notmuch@notmuchmail.org>; Wed, 4 Jul 2012 09:31:47 -0700 (PDT)
\r
20 Received: by guru.guru-group.fi (Postfix, from userid 501)
\r
21 id 6BBEF100637; Wed, 4 Jul 2012 19:31:57 +0300 (EEST)
\r
22 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
23 To: Austin Clements <amdragon@MIT.EDU>,
\r
24 Mark Walters <markwalters1009@gmail.com>
\r
25 Subject: Re: [PATCH 1/8] emacs: Clean up notmuch-search-show-result
\r
26 In-Reply-To: <20120704162243.GC21653@mit.edu>
\r
27 References: <1341354059-29396-1-git-send-email-amdragon@mit.edu>
\r
28 <1341354059-29396-2-git-send-email-amdragon@mit.edu>
\r
29 <87lij0gdwt.fsf@qmul.ac.uk> <20120704162243.GC21653@mit.edu>
\r
30 User-Agent: Notmuch/0.13.2+73~g94db390 (http://notmuchmail.org) Emacs/23.1.1
\r
31 (x86_64-redhat-linux-gnu)
\r
32 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
33 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
34 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
35 Date: Wed, 04 Jul 2012 19:31:57 +0300
\r
36 Message-ID: <m2zk7febcy.fsf@guru.guru-group.fi>
\r
38 Content-Type: text/plain; charset=us-ascii
\r
39 Cc: notmuch@notmuchmail.org
\r
40 X-BeenThere: notmuch@notmuchmail.org
\r
41 X-Mailman-Version: 2.1.13
\r
43 List-Id: "Use and development of the notmuch mail system."
\r
44 <notmuch.notmuchmail.org>
\r
45 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
46 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
47 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
48 List-Post: <mailto:notmuch@notmuchmail.org>
\r
49 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
50 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
51 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
52 X-List-Received-Date: Wed, 04 Jul 2012 16:31:48 -0000
\r
54 On Wed, Jul 04 2012, Austin Clements <amdragon@MIT.EDU> wrote:
\r
56 > Quoth Mark Walters on Jul 04 at 8:53 am:
\r
57 >> On Tue, 03 Jul 2012, Austin Clements <amdragon@MIT.EDU> wrote:
\r
58 >> > This simplifies the code and makes it no longer cubic in the number of
\r
61 >> This looks good to me and all tests pass, and I agree that this patch
\r
62 >> can be pushed independently of the later patches in the series.
\r
64 >> My one comment is that I, as a lisp beginner, found the use of "format"
\r
65 >> as a function and a variable confusing (particularly as I had not come
\r
66 >> across the dolist macro and that use really makes format look like a
\r
69 > I can see how that would be confusing. Unless this version of the
\r
70 > series is somehow perfect, I'll rename it in the second version.
\r
71 > Perhaps result-format for the loop variable and spec for the format
\r
74 There are 'format' variables elsewhere too -- on those places it could
\r
75 be renamed as 'format-string' (as used else-elsewhere and the format
\r
76 documentation refers to STRING). As an analogy to that the 'format' in
\r
77 this particular dolist usage could be 'format-pair' ? (but anything goes,
\r
78 even the current 'format').
\r