From: Tomi Ollila <tomi.ollila@iki.fi>
To: Austin Clements <amdragon@MIT.EDU>,
	Mark Walters <markwalters1009@gmail.com>
Subject: Re: [PATCH 1/8] emacs: Clean up notmuch-search-show-result
In-Reply-To: <20120704162243.GC21653@mit.edu>
References: <1341354059-29396-1-git-send-email-amdragon@mit.edu>
	<1341354059-29396-2-git-send-email-amdragon@mit.edu>
	<87lij0gdwt.fsf@qmul.ac.uk> <20120704162243.GC21653@mit.edu>
User-Agent: Notmuch/0.13.2+73~g94db390 (http://notmuchmail.org) Emacs/23.1.1
	(x86_64-redhat-linux-gnu)
Date: Wed, 04 Jul 2012 19:31:57 +0300
Message-ID: <m2zk7febcy.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: notmuch@notmuchmail.org
Precedence: list

On Wed, Jul 04 2012, Austin Clements <amdragon@MIT.EDU> wrote:

> Quoth Mark Walters on Jul 04 at  8:53 am:
>> On Tue, 03 Jul 2012, Austin Clements <amdragon@MIT.EDU> wrote:
>> > This simplifies the code and makes it no longer cubic in the number of
>> > result fields.
>> 
>> This looks good to me and all tests pass, and I agree that this patch
>> can be pushed independently of the later patches in the series.
>> 
>> My one comment is that I, as a lisp beginner, found the use of "format"
>> as a function and a variable confusing (particularly as I had not come
>> across the dolist macro and that use really makes format look like a
>> function).
>
> I can see how that would be confusing.  Unless this version of the
> series is somehow perfect, I'll rename it in the second version.
> Perhaps result-format for the loop variable and spec for the format
> string argument?

There are 'format' variables elsewhere too -- on those places it could
be renamed as 'format-string' (as used else-elsewhere and the format
documentation refers to STRING). As an analogy to that the 'format' in
this particular dolist usage could be 'format-pair' ? (but anything goes,
even the current 'format').

Tomi

>
>> Best wishes
>> 
>> Mark