1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 616B3429E26
\r
6 for <notmuch@notmuchmail.org>; Tue, 6 Dec 2011 12:55:45 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 48ZYXlC3H8nc for <notmuch@notmuchmail.org>;
\r
16 Tue, 6 Dec 2011 12:55:45 -0800 (PST)
\r
17 Received: from mail-fx0-f53.google.com (mail-fx0-f53.google.com
\r
18 [209.85.161.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id BACD7429E21
\r
21 for <notmuch@notmuchmail.org>; Tue, 6 Dec 2011 12:55:44 -0800 (PST)
\r
22 Received: by faaa5 with SMTP id a5so86696faa.26
\r
23 for <notmuch@notmuchmail.org>; Tue, 06 Dec 2011 12:55:43 -0800 (PST)
\r
24 Received: by 10.180.18.233 with SMTP id z9mr8927063wid.0.1323204943517;
\r
25 Tue, 06 Dec 2011 12:55:43 -0800 (PST)
\r
26 Received: from localhost (dsl-hkibrasgw4-fe5cdc00-23.dhcp.inet.fi.
\r
28 by mx.google.com with ESMTPS id u5sm29027511wbm.2.2011.12.06.12.55.41
\r
29 (version=SSLv3 cipher=OTHER); Tue, 06 Dec 2011 12:55:42 -0800 (PST)
\r
30 From: Jani Nikula <jani@nikula.org>
\r
31 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
\r
32 Subject: Re: [PATCH 1/4] notmuch-opts.[ch]: new argument parsing framework for
\r
34 In-Reply-To: <1323013675-6929-2-git-send-email-david@tethera.net>
\r
35 References: <1323013675-6929-1-git-send-email-david@tethera.net>
\r
36 <1323013675-6929-2-git-send-email-david@tethera.net>
\r
37 User-Agent: Notmuch/0.10.1+59~ga1814f2 (http://notmuchmail.org) Emacs/23.3.1
\r
39 Date: Tue, 06 Dec 2011 22:55:39 +0200
\r
40 Message-ID: <87r50hxvw4.fsf@nikula.org>
\r
42 Content-Type: text/plain; charset=us-ascii
\r
43 Cc: David Bremner <bremner@debian.org>
\r
44 X-BeenThere: notmuch@notmuchmail.org
\r
45 X-Mailman-Version: 2.1.13
\r
47 List-Id: "Use and development of the notmuch mail system."
\r
48 <notmuch.notmuchmail.org>
\r
49 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
51 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
52 List-Post: <mailto:notmuch@notmuchmail.org>
\r
53 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
54 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
56 X-List-Received-Date: Tue, 06 Dec 2011 20:55:45 -0000
\r
58 On Sun, 4 Dec 2011 11:47:52 -0400, David Bremner <david@tethera.net> wrote:
\r
59 > + case NOTMUCH_OPT_INT:
\r
60 > + if (try->output_var)
\r
61 > + *((int *)try->output_var) =
\r
62 > + atol (arg + strlen (try->name) + 1);
\r
64 Looking at patch 4 and the existing handling of int params, I'd really
\r
65 like this one to check that the string is non-empty and that all of the
\r
66 string is parsed (and doesn't contain garbage at the end).
\r