Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 616B3429E26 for ; Tue, 6 Dec 2011 12:55:45 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 48ZYXlC3H8nc for ; Tue, 6 Dec 2011 12:55:45 -0800 (PST) Received: from mail-fx0-f53.google.com (mail-fx0-f53.google.com [209.85.161.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id BACD7429E21 for ; Tue, 6 Dec 2011 12:55:44 -0800 (PST) Received: by faaa5 with SMTP id a5so86696faa.26 for ; Tue, 06 Dec 2011 12:55:43 -0800 (PST) Received: by 10.180.18.233 with SMTP id z9mr8927063wid.0.1323204943517; Tue, 06 Dec 2011 12:55:43 -0800 (PST) Received: from localhost (dsl-hkibrasgw4-fe5cdc00-23.dhcp.inet.fi. [80.220.92.23]) by mx.google.com with ESMTPS id u5sm29027511wbm.2.2011.12.06.12.55.41 (version=SSLv3 cipher=OTHER); Tue, 06 Dec 2011 12:55:42 -0800 (PST) From: Jani Nikula To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH 1/4] notmuch-opts.[ch]: new argument parsing framework for notmuch. In-Reply-To: <1323013675-6929-2-git-send-email-david@tethera.net> References: <1323013675-6929-1-git-send-email-david@tethera.net> <1323013675-6929-2-git-send-email-david@tethera.net> User-Agent: Notmuch/0.10.1+59~ga1814f2 (http://notmuchmail.org) Emacs/23.3.1 (i686-pc-linux-gnu) Date: Tue, 06 Dec 2011 22:55:39 +0200 Message-ID: <87r50hxvw4.fsf@nikula.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Bremner X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Dec 2011 20:55:45 -0000 On Sun, 4 Dec 2011 11:47:52 -0400, David Bremner wrote: > + case NOTMUCH_OPT_INT: > + if (try->output_var) > + *((int *)try->output_var) = > + atol (arg + strlen (try->name) + 1); Looking at patch 4 and the existing handling of int params, I'd really like this one to check that the string is non-empty and that all of the string is parsed (and doesn't contain garbage at the end). BR, Jani.