1 Return-Path: <alex.boterolowry@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id C8E28431FBC
\r
6 for <notmuch@notmuchmail.org>; Sat, 21 Nov 2009 20:17:16 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
8 Received: from olra.theworths.org ([127.0.0.1])
\r
9 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
10 with ESMTP id 9UdNpj+Yqq-L for <notmuch@notmuchmail.org>;
\r
11 Sat, 21 Nov 2009 20:17:16 -0800 (PST)
\r
12 Received: from mail-yx0-f204.google.com (mail-yx0-f204.google.com
\r
14 by olra.theworths.org (Postfix) with ESMTP id F4122431FAE
\r
15 for <notmuch@notmuchmail.org>; Sat, 21 Nov 2009 20:17:15 -0800 (PST)
\r
16 Received: by yxe42 with SMTP id 42so4577925yxe.22
\r
17 for <notmuch@notmuchmail.org>; Sat, 21 Nov 2009 20:17:15 -0800 (PST)
\r
18 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
19 h=domainkey-signature:received:received:received:from:to:subject
\r
20 :in-reply-to:references:date:message-id:mime-version:content-type;
\r
21 bh=yeNwB4FeJe5/7H2rWr8QZtO0wSVfjQzwEgyUM00pNng=;
\r
22 b=iio1bEnaYK/H1tVAKs/V4mnKO1xpKQMk+naRBf1TYhDQfGIbwkWWq1c1viBH2CcddW
\r
23 AcfKqBMHNSVGX/FKfZu9k6bqdKEvAp+0O6uzAylhrT7KelyKhqifg3FDz1AwGSM5woOt
\r
24 YV/ciohacsga+6AizLM5R/uzagRzIGfJwkZjA=
\r
25 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
\r
26 h=from:to:subject:in-reply-to:references:date:message-id:mime-version
\r
28 b=xnoYSrUGqMpDR+FYmHGaEaqBA7x/JN/GkhwVWhadO6H5pC55fsbCY5yZp9NtffhsCo
\r
29 1ZhIDaWoLoDJYq8Qbwo+6kUUrn6djTXCVuLYiJAvENhbdiV/S+jw3h5ydGLGQMXvaeLG
\r
30 j4nf8rON1N4ahYoKTkuo7ESBV/HioqQV16wo4=
\r
31 Received: by 10.150.71.31 with SMTP id t31mr5879445yba.18.1258863435592;
\r
32 Sat, 21 Nov 2009 20:17:15 -0800 (PST)
\r
33 Received: from fortitudo (70-36-144-85.dsl.dynamic.sonic.net [70.36.144.85])
\r
34 by mx.google.com with ESMTPS id 15sm1495919gxk.0.2009.11.21.20.17.14
\r
35 (version=TLSv1/SSLv3 cipher=RC4-MD5);
\r
36 Sat, 21 Nov 2009 20:17:15 -0800 (PST)
\r
37 Received: from alexbl (uid 1001) (envelope-from
\r
38 alexbl@fortitudo.i-did-not-set--mail-host-address--so-tickle-me)
\r
39 id 70d5 by fortitudo (DragonFly Mail Agent)
\r
40 Sat, 21 Nov 2009 20:17:17 -0800
\r
41 From: Alexander Botero-Lowry <alex.boterolowry@gmail.com>
\r
42 To: Jjgod Jiang <gzjjgod@gmail.com>, notmuch@notmuchmail.org
\r
43 In-Reply-To: <1258859256-33197-1-git-send-email-gzjjgod@gmail.com>
\r
44 References: <1258859256-33197-1-git-send-email-gzjjgod@gmail.com>
\r
45 Date: Sat, 21 Nov 2009 20:17:17 -0800
\r
47 <86pr7b9os2.fsf@fortitudo.i-did-not-set--mail-host-address--so-tickle-me>
\r
49 Content-Type: text/plain; charset=us-ascii
\r
50 Subject: Re: [notmuch] [PATCH] Mac OS X compatibility fixes
\r
51 X-BeenThere: notmuch@notmuchmail.org
\r
52 X-Mailman-Version: 2.1.12
\r
54 List-Id: "Use and development of the notmuch mail system."
\r
55 <notmuch.notmuchmail.org>
\r
56 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
57 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
58 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
59 List-Post: <mailto:notmuch@notmuchmail.org>
\r
60 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
61 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
62 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
63 X-List-Received-Date: Sun, 22 Nov 2009 04:17:16 -0000
\r
65 On Sun, 22 Nov 2009 11:07:36 +0800, Jjgod Jiang <gzjjgod@gmail.com> wrote:
\r
66 > Add missing GNU extensions strdup() and getline(). The C library
\r
67 > shipped with Mac OS X does not include them (though it does support
\r
68 > some GNU extensions when _GNU_SOURCE is defined), so we have to
\r
69 > add these two. The getline() implementation is a modified version
\r
70 > of getdelim() from GNU Libc.
\r
73 > diff --git a/lib/xutil.c b/lib/xutil.c
\r
74 > index 6fa5eb0..805b236 100644
\r
77 > @@ -79,6 +79,105 @@ xstrdup (const char *s)
\r
84 This should be done in a capabilites way, for example strndup was added
\r
85 to FreeBSD in 7.2 (which is this current release of the 7 line), and so
\r
86 for older versions of FreeBSD strndup will be needed. getdelim() and
\r
87 getline() came in FreeBSD 8, so they'll be needed for the entire 7 line.
\r
88 So Instead of just assuming __APPLE__ this should be done by determing
\r
89 if the symbols are generally needed.
\r