DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=from:to:subject:in-reply-to:references:date:message-id:mime-version
	:content-type;
	b=xnoYSrUGqMpDR+FYmHGaEaqBA7x/JN/GkhwVWhadO6H5pC55fsbCY5yZp9NtffhsCo
	1ZhIDaWoLoDJYq8Qbwo+6kUUrn6djTXCVuLYiJAvENhbdiV/S+jw3h5ydGLGQMXvaeLG
	j4nf8rON1N4ahYoKTkuo7ESBV/HioqQV16wo4=
From: Alexander Botero-Lowry <alex.boterolowry@gmail.com>
To: Jjgod Jiang <gzjjgod@gmail.com>, notmuch@notmuchmail.org
In-Reply-To: <1258859256-33197-1-git-send-email-gzjjgod@gmail.com>
References: <1258859256-33197-1-git-send-email-gzjjgod@gmail.com>
Date: Sat, 21 Nov 2009 20:17:17 -0800
Message-ID:
 <86pr7b9os2.fsf@fortitudo.i-did-not-set--mail-host-address--so-tickle-me>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [notmuch] [PATCH] Mac OS X compatibility fixes
Precedence: list

On Sun, 22 Nov 2009 11:07:36 +0800, Jjgod Jiang <gzjjgod@gmail.com> wrote:
> Add missing GNU extensions strdup() and getline(). The C library
> shipped with Mac OS X does not include them (though it does support
> some GNU extensions when _GNU_SOURCE is defined), so we have to
> add these two. The getline() implementation is a modified version
> of getdelim() from GNU Libc.
Awesome!

> diff --git a/lib/xutil.c b/lib/xutil.c
> index 6fa5eb0..805b236 100644
> --- a/lib/xutil.c
> +++ b/lib/xutil.c
> @@ -79,6 +79,105 @@ xstrdup (const char *s)
>      return ret;
>  }
>  
> +#ifdef __APPLE__
Not awesome.

This should be done in a capabilites way, for example strndup was added
to FreeBSD in 7.2 (which is this current release of the 7 line), and so
for older versions of FreeBSD strndup will be needed. getdelim() and
getline() came in FreeBSD 8, so they'll be needed for the entire 7 line.
So Instead of just assuming __APPLE__ this should be done by determing
if the symbols are generally needed.

alex