43/4213285cb0d99211ee3304e9da3cebe6439b45

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id B4345431FD0\r
   6         for <notmuch@notmuchmail.org>; Fri,  9 Dec 2011 11:52:50 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id ZPzba7njR6qG for <notmuch@notmuchmail.org>;\r
  16         Fri,  9 Dec 2011 11:52:48 -0800 (PST)\r
  17 Received: from dmz-mailsec-scanner-8.mit.edu (DMZ-MAILSEC-SCANNER-8.MIT.EDU\r
  18         [18.7.68.37])\r
  19         by olra.theworths.org (Postfix) with ESMTP id AECBE431FB6\r
  20         for <notmuch@notmuchmail.org>; Fri,  9 Dec 2011 11:52:48 -0800 (PST)\r
  21 X-AuditID: 12074425-b7f116d0000008fe-86-4ee2671090ee\r
  22 Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])\r
  23         by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id 3C.5B.02302.01762EE4; Fri,  9 Dec 2011 14:52:48 -0500 (EST)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id pB9JqlBG032110; \r
  27         Fri, 9 Dec 2011 14:52:48 -0500\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id pB9JqjfV012192\r
  32         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
  33         Fri, 9 Dec 2011 14:52:46 -0500 (EST)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1RZ6WY-0000K3-9j; Fri, 09 Dec 2011 14:54:26 -0500\r
  37 Date: Fri, 9 Dec 2011 14:54:26 -0500\r
  38 From: Austin Clements <amdragon@MIT.EDU>\r
  39 To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
  40 Subject: Re: [PATCH 1/4] show: Pass notmuch_message_t instead of path to\r
  41         show_message_body.\r
  42 Message-ID: <20111209195426.GJ3190@mit.edu>\r
  43 References: <1322446871-14986-1-git-send-email-amdragon@mit.edu>\r
  44         <1323027100-10307-1-git-send-email-amdragon@mit.edu>\r
  45         <1323027100-10307-2-git-send-email-amdragon@mit.edu>\r
  46         <87ty597eh8.fsf@gmail.com>\r
  47 MIME-Version: 1.0\r
  48 Content-Type: text/plain; charset=us-ascii\r
  49 Content-Disposition: inline\r
  50 In-Reply-To: <87ty597eh8.fsf@gmail.com>\r
  51 User-Agent: Mutt/1.5.21 (2010-09-15)\r
  52 X-Brightmail-Tracker:\r
  53  H4sIAAAAAAAAA+NgFmphleLIzCtJLcpLzFFi42IRYrdT1xVIf+Rn0HFYwOLq1n52i+s3ZzI7\r
  54         MHnsnHWX3ePZqlvMAUxRXDYpqTmZZalF+nYJXBm7e96zF5znqGh/s4m9gfEnWxcjJ4eEgInE\r
  55         z71PWCBsMYkL99YDxbk4hAT2MUocnNfACOGsZ5RYurmBBcI5wSSxv2MPVNkSRolHT7cxgvSz\r
  56         CKhIfJi0hQnEZhPQkNi2fzlYXETAUOLWxVfMIDazgLTEt9/NYDXCArESDRvug8V5BbQlDu/Z\r
  57         wgox9DSjxMlNj9ggEoISJ2dCHMgsoCVx499LoGYOsEHL/3GAmJwC6hJbbzmBVIgCnTDl5Da2\r
  58         CYxCs5A0z0LSPAuheQEj8ypG2ZTcKt3cxMyc4tRk3eLkxLy81CJdC73czBK91JTSTYzgwHZR\r
  59         3cE44ZDSIUYBDkYlHl5Pr0d+QqyJZcWVuYcYJTmYlER541KAQnxJ+SmVGYnFGfFFpTmpxYcY\r
  60         JTiYlUR4VeSBcrwpiZVVqUX5MClpDhYlcd6GXQ/9hATSE0tSs1NTC1KLYLIyHBxKErwBqUCN\r
  61         gkWp6akVaZk5JQhpJg5OkOE8QMNDI0GGFxck5hZnpkPkTzEqSonzmoAkBEASGaV5cL2wxPOK\r
  62         URzoFWFeJZAqHmDSgut+BTSYCWjwl+wHIINLEhFSUg2MjBeYzzTav72tc+/SQSNP1n8OH76m\r
  63         PnsltDdq4stdt7z+LAl47eF5TVXq8MpJE2bWbwyxcaht1/wxe9r+X78PO33YV/2/8Gd2kPfc\r
  64         5Iim5Cm8Ft+vFF07KVa3N+PF5kM3TRZaVLC/FzmvFSsw/+oSlRP/upu/ytmGP1D85VaTujfG\r
  65         X3Bq16fdHUosxRmJhlrMRcWJADh+3DsXAwAA\r
  66 Cc: notmuch@notmuchmail.org\r
  67 X-BeenThere: notmuch@notmuchmail.org\r
  68 X-Mailman-Version: 2.1.13\r
  69 Precedence: list\r
  70 List-Id: "Use and development of the notmuch mail system."\r
  71         <notmuch.notmuchmail.org>\r
  72 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  73         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  74 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  75 List-Post: <mailto:notmuch@notmuchmail.org>\r
  76 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  77 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  78         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  79 X-List-Received-Date: Fri, 09 Dec 2011 19:52:50 -0000\r
  80 \r
  81 Quoth Dmitry Kurochkin on Dec 09 at 11:05 pm:\r
  82 > On Sun,  4 Dec 2011 14:31:37 -0500, Austin Clements <amdragon@MIT.EDU> wrote:\r
  83 > >  }\r
  84 > >  \r
  85 > >  notmuch_status_t\r
  86 > > -show_message_body (const char *filename,\r
  87 > > +show_message_body (notmuch_message_t *message,\r
  88 > >                const notmuch_show_format_t *format,\r
  89 > >                notmuch_show_params_t *params)\r
  90 > \r
  91 > Is show_message_body() (or functions that it calls/would call) supposed\r
  92 > to modify the message structure?  If not, we should make it const.\r
  93 \r
  94 That would be nice, but lack of const in libnotmuch makes it difficult\r
  95 to do this (for example, notmuch_message_get_filename, which\r
  96 show_message_body calls, takes a non-const notmuch_message_t *).\r
  97 \r
  98 OTOH, since functions like notmuch_message_get_filename lazily compute\r
  99 fields of notmuch_message_t and C has no equivalent of C++'s mutable,\r
 100 it's not clear making the message const is even the right thing to do.\r
 101 \r
 102 > I would also make all pointers constant (i.e. const notmuch_message_t\r
 103 > *const message), but I can not insist since it is not common in notmuch.\r
 104 > \r
 105 > Regards,\r
 106 >   Dmitry\r