1 Return-Path: <dme@dme.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 4C559431FD0
\r
6 for <notmuch@notmuchmail.org>; Mon, 9 Jan 2012 23:25:47 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id bnTNkhKtDFE5 for <notmuch@notmuchmail.org>;
\r
16 Mon, 9 Jan 2012 23:25:43 -0800 (PST)
\r
17 Received: from mail-we0-f181.google.com (mail-we0-f181.google.com
\r
18 [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 2082C431FB6
\r
21 for <notmuch@notmuchmail.org>; Mon, 9 Jan 2012 23:25:43 -0800 (PST)
\r
22 Received: by werm12 with SMTP id m12so3924359wer.26
\r
23 for <notmuch@notmuchmail.org>; Mon, 09 Jan 2012 23:25:40 -0800 (PST)
\r
24 Received: by 10.216.138.151 with SMTP id a23mr8680159wej.52.1326180340467;
\r
25 Mon, 09 Jan 2012 23:25:40 -0800 (PST)
\r
26 Received: from hotblack-desiato.hh.sledj.net
\r
27 (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25])
\r
28 by mx.google.com with ESMTPS id f36sm38764046wbo.10.2012.01.09.23.25.38
\r
29 (version=TLSv1/SSLv3 cipher=OTHER);
\r
30 Mon, 09 Jan 2012 23:25:39 -0800 (PST)
\r
31 Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000)
\r
32 id D6AC2A05E9; Tue, 10 Jan 2012 07:25:36 +0000 (GMT)
\r
33 To: Adam Wolfe Gordon <awg@xvx.ca>
\r
34 Subject: Re: [PATCH 4/4] emacs: Use the new JSON reply format.
\r
36 <CAMoJFUt8F417wzSmiHDv2KHa9y5ARYh=xRHKEsWBXYXHfaN64A@mail.gmail.com>
\r
37 References: <1326009162-19524-1-git-send-email-awg+notmuch@xvx.ca>
\r
38 <1326009162-19524-5-git-send-email-awg+notmuch@xvx.ca>
\r
39 <cun62gl1cqv.fsf@hotblack-desiato.hh.sledj.net>
\r
40 <CAMoJFUt8F417wzSmiHDv2KHa9y5ARYh=xRHKEsWBXYXHfaN64A@mail.gmail.com>
\r
41 User-Agent: Notmuch/0.10.2+151~gbf1dc2b (http://notmuchmail.org)
\r
42 Emacs/24.0.92.1 (x86_64-pc-linux-gnu)
\r
43 From: David Edmondson <dme@dme.org>
\r
44 Date: Tue, 10 Jan 2012 07:25:32 +0000
\r
45 Message-ID: <cun39boow7n.fsf@hotblack-desiato.hh.sledj.net>
\r
47 Content-Type: multipart/signed; boundary="=-=-=";
\r
48 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
49 Cc: notmuch@notmuchmail.org
\r
50 X-BeenThere: notmuch@notmuchmail.org
\r
51 X-Mailman-Version: 2.1.13
\r
53 List-Id: "Use and development of the notmuch mail system."
\r
54 <notmuch.notmuchmail.org>
\r
55 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
56 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
57 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
58 List-Post: <mailto:notmuch@notmuchmail.org>
\r
59 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
60 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
61 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
62 X-List-Received-Date: Tue, 10 Jan 2012 07:25:47 -0000
\r
65 Content-Type: text/plain
\r
66 Content-Transfer-Encoding: quoted-printable
\r
68 On Mon, 9 Jan 2012 19:10:48 -0700, Adam Wolfe Gordon <awg@xvx.ca> wrote:
\r
69 > > Using w3m means that you should `require' it. What happens when a user
\r
70 > > doesn't have it? (Either the elisp or the command.)
\r
72 > This was my initial thought, but when I looked at notmuch-show.el,
\r
73 > which uses w3m features, I noticed that it doesn't have a require. To
\r
74 > be clear, this patch requires w3m.el (not just the w3m binary), which
\r
75 > I don't think anything else in notmuch does.
\r
77 > In the previous version I had a customize variable specifying whether
\r
78 > to quote HTML parts, which meant that if the user could set the
\r
79 > customize variable to false and everything would work without w3m.el.
\r
80 > I'd like not to introduce a new prerequisite, so if there's a way to
\r
81 > make w3m.el optional that would be my preference. Can you provide
\r
82 > some guidance on this?
\r
84 My suggestion would be to move the `html to text' functionality to a new
\r
85 .el, as we might have more than one way to achieve it (emacs 24 has
\r
86 `shr', for example).
\r
88 Have `notmuch-mua.el' use a generically named function to perform the
\r
89 transformation from html to text and that function should determine the
\r
90 best way to achieve it.
\r
92 Testing for `w3m.el' is relatively easy (`require' it and check for
\r
93 error). Testing for `w3m' itself can be done using some code similar to
\r
94 `notmuch-address-locate-command' (search the list - it's not yet
\r
95 integrated), which is itself just copied from w3m (and should end up in
\r
99 Content-Type: application/pgp-signature
\r
101 -----BEGIN PGP SIGNATURE-----
\r
102 Version: GnuPG v1.4.11 (GNU/Linux)
\r
104 iEYEARECAAYFAk8L5+wACgkQaezQq/BJZRYd1gCdH/Yct01nvLCKJGPt7PnwErVx
\r
105 GWAAniT5KgNj7sUUvH1KUICjs0XApsOs
\r
107 -----END PGP SIGNATURE-----
\r