To: Adam Wolfe Gordon <awg@xvx.ca>
Subject: Re: [PATCH 4/4] emacs: Use the new JSON reply format.
In-Reply-To:
 <CAMoJFUt8F417wzSmiHDv2KHa9y5ARYh=xRHKEsWBXYXHfaN64A@mail.gmail.com>
References: <1326009162-19524-1-git-send-email-awg+notmuch@xvx.ca>
	<1326009162-19524-5-git-send-email-awg+notmuch@xvx.ca>
	<cun62gl1cqv.fsf@hotblack-desiato.hh.sledj.net>
	<CAMoJFUt8F417wzSmiHDv2KHa9y5ARYh=xRHKEsWBXYXHfaN64A@mail.gmail.com>
User-Agent: Notmuch/0.10.2+151~gbf1dc2b (http://notmuchmail.org)
	Emacs/24.0.92.1 (x86_64-pc-linux-gnu)
From: David Edmondson <dme@dme.org>
Date: Tue, 10 Jan 2012 07:25:32 +0000
Message-ID: <cun39boow7n.fsf@hotblack-desiato.hh.sledj.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Cc: notmuch@notmuchmail.org
Precedence: list

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Mon, 9 Jan 2012 19:10:48 -0700, Adam Wolfe Gordon <awg@xvx.ca> wrote:
> > Using w3m means that you should `require' it. What happens when a user
> > doesn't have it? (Either the elisp or the command.)
>=20
> This was my initial thought, but when I looked at notmuch-show.el,
> which uses w3m features, I noticed that it doesn't have a require.  To
> be clear, this patch requires w3m.el (not just the w3m binary), which
> I don't think anything else in notmuch does.
>=20
> In the previous version I had a customize variable specifying whether
> to quote HTML parts, which meant that if the user could set the
> customize variable to false and everything would work without w3m.el.
> I'd like not to introduce a new prerequisite, so if there's a way to
> make w3m.el optional that would be my preference.  Can you provide
> some guidance on this?

My suggestion would be to move the `html to text' functionality to a new
.el, as we might have more than one way to achieve it (emacs 24 has
`shr', for example).

Have `notmuch-mua.el' use a generically named function to perform the
transformation from html to text and that function should determine the
best way to achieve it.

Testing for `w3m.el' is relatively easy (`require' it and check for
error). Testing for `w3m' itself can be done using some code similar to
`notmuch-address-locate-command' (search the list - it's not yet
integrated), which is itself just copied from w3m (and should end up in
`notmuch-lib.el').

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk8L5+wACgkQaezQq/BJZRYd1gCdH/Yct01nvLCKJGPt7PnwErVx
GWAAniT5KgNj7sUUvH1KUICjs0XApsOs
=IwEr
-----END PGP SIGNATURE-----
--=-=-=--