1 Return-Path: <dme@dme.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id F1256429E25
\r
6 for <notmuch@notmuchmail.org>; Mon, 26 Dec 2011 02:54:19 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id Ej3BtqQQ-MpB for <notmuch@notmuchmail.org>;
\r
16 Mon, 26 Dec 2011 02:54:19 -0800 (PST)
\r
17 Received: from mail-we0-f181.google.com (mail-we0-f181.google.com
\r
18 [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 67F77431FD0
\r
21 for <notmuch@notmuchmail.org>; Mon, 26 Dec 2011 02:54:19 -0800 (PST)
\r
22 Received: by werm12 with SMTP id m12so6159859wer.26
\r
23 for <notmuch@notmuchmail.org>; Mon, 26 Dec 2011 02:54:18 -0800 (PST)
\r
24 Received: by 10.216.138.148 with SMTP id a20mr18863137wej.15.1324896858010;
\r
25 Mon, 26 Dec 2011 02:54:18 -0800 (PST)
\r
26 Received: from hotblack-desiato.hh.sledj.net
\r
27 (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25])
\r
28 by mx.google.com with ESMTPS id q34sm10019645wbm.15.2011.12.26.02.54.16
\r
29 (version=TLSv1/SSLv3 cipher=OTHER);
\r
30 Mon, 26 Dec 2011 02:54:16 -0800 (PST)
\r
31 Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000)
\r
32 id CA416A0765; Mon, 26 Dec 2011 10:54:14 +0000 (GMT)
\r
33 To: Aaron Ecay <aaronecay@gmail.com>, Austin Clements <amdragon@MIT.EDU>
\r
34 Subject: Re: [RFC][PATCH v4] emacs: Re-implement advance/rewind functions of
\r
36 In-Reply-To: <m2zkegt1jk.fsf@gmail.com>
\r
37 References: <id:"1324553312-10972-1-git-send-email-dme@dme.org">
\r
38 <1324665712-2419-1-git-send-email-dme@dme.org>
\r
39 <20111225010635.GG1927@mit.edu> <m2zkegt1jk.fsf@gmail.com>
\r
40 User-Agent: Notmuch/0.10.2+107~ga2d0215 (http://notmuchmail.org)
\r
41 Emacs/24.0.92.1 (x86_64-pc-linux-gnu)
\r
42 From: David Edmondson <dme@dme.org>
\r
43 Date: Mon, 26 Dec 2011 10:54:14 +0000
\r
44 Message-ID: <cunipl3txgp.fsf@hotblack-desiato.hh.sledj.net>
\r
46 Content-Type: multipart/signed; boundary="=-=-=";
\r
47 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
48 Cc: notmuch@notmuchmail.org
\r
49 X-BeenThere: notmuch@notmuchmail.org
\r
50 X-Mailman-Version: 2.1.13
\r
52 List-Id: "Use and development of the notmuch mail system."
\r
53 <notmuch.notmuchmail.org>
\r
54 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
56 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
57 List-Post: <mailto:notmuch@notmuchmail.org>
\r
58 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
59 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
60 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
61 X-List-Received-Date: Mon, 26 Dec 2011 10:54:20 -0000
\r
64 Content-Type: text/plain
\r
65 Content-Transfer-Encoding: quoted-printable
\r
67 On Sun, 25 Dec 2011 23:11:27 -0500, Aaron Ecay <aaronecay@gmail.com> wrote:
\r
68 > > > + ((> (let ((visible-bottom (notmuch-show-message-bottom)))
\r
69 > > > + (while (invisible-p visible-bottom)
\r
70 > > > + (setq visible-bottom (max (point-min)
\r
71 > > > + (1- (previous-single-char-property-change
\r
72 > > > + visible-bottom 'invisible)))))
\r
73 > > > + visible-bottom) (window-end))
\r
75 > Can this (let...) be lifted out of the (cond...)? IMO it is very
\r
76 > confusing to be doing non-trivial computation in the test portion of a
\r
79 It ends up a long way from where it's used, diluting the value of the
\r
80 comment. I do like the current layout, but what if it was (something
\r
83 ((let ((visible-bottom (1- (notmuch-show-message-bottom))))
\r
84 (while (invisible-p visible-bottom)
\r
85 (setq visible-bottom (max (point-min)
\r
86 (1- (previous-single-char-property-change
\r
87 visible-bottom 'invisible)))))
\r
88 (> visible-bottom (window-end)))
\r
89 ;; The end of this message is not visible - scroll to show more of
\r
94 That would seem more palatable, perhaps.
\r
96 > Agreed. I would like to see this case move back one screenful of text or
\r
97 > to the previous beginning-of-message, whichever is shorter.
\r
99 See previous comment - I agreed that it's not symmetric - just wonder
\r
100 which is more useful behaviour.
\r
103 Content-Type: application/pgp-signature
\r
105 -----BEGIN PGP SIGNATURE-----
\r
106 Version: GnuPG v1.4.11 (GNU/Linux)
\r
108 iEYEARECAAYFAk74UlYACgkQaezQq/BJZRZ7TwCfdlYvGn+kEAMdLLI8FnE7UMf4
\r
109 YVgAnAv/f/B6XOCMeCf2gf28ZthJ5JV/
\r
111 -----END PGP SIGNATURE-----
\r