To: Aaron Ecay <aaronecay@gmail.com>, Austin Clements <amdragon@MIT.EDU>
Subject: Re: [RFC][PATCH v4] emacs: Re-implement advance/rewind functions of
	notmuch-show-mode.
In-Reply-To: <m2zkegt1jk.fsf@gmail.com>
References: <id:"1324553312-10972-1-git-send-email-dme@dme.org">
	<1324665712-2419-1-git-send-email-dme@dme.org>
	<20111225010635.GG1927@mit.edu> <m2zkegt1jk.fsf@gmail.com>
User-Agent: Notmuch/0.10.2+107~ga2d0215 (http://notmuchmail.org)
	Emacs/24.0.92.1 (x86_64-pc-linux-gnu)
From: David Edmondson <dme@dme.org>
Date: Mon, 26 Dec 2011 10:54:14 +0000
Message-ID: <cunipl3txgp.fsf@hotblack-desiato.hh.sledj.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Cc: notmuch@notmuchmail.org
Precedence: list

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Sun, 25 Dec 2011 23:11:27 -0500, Aaron Ecay <aaronecay@gmail.com> wrote:
> > > +   ((> (let ((visible-bottom (notmuch-show-message-bottom)))
> > > +	 (while (invisible-p visible-bottom)
> > > +	   (setq visible-bottom (max (point-min)
> > > +				     (1- (previous-single-char-property-change
> > > +					  visible-bottom 'invisible)))))
> > > +	 visible-bottom) (window-end))
>=20
> Can this (let...) be lifted out of the (cond...)?  IMO it is very
> confusing to be doing non-trivial computation in the test portion of a
> cond form.

It ends up a long way from where it's used, diluting the value of the
comment. I do like the current layout, but what if it was (something
like):

   ((let ((visible-bottom (1- (notmuch-show-message-bottom))))
      (while (invisible-p visible-bottom)
	(setq visible-bottom (max (point-min)
				  (1- (previous-single-char-property-change
				       visible-bottom 'invisible)))))
      (> visible-bottom (window-end)))
    ;; The end of this message is not visible - scroll to show more of
    ;; it.
    (scroll-up)
    nil)

That would seem more palatable, perhaps.

> Agreed.  I would like to see this case move back one screenful of text or
> to the previous beginning-of-message, whichever is shorter.

See previous comment - I agreed that it's not symmetric - just wonder
which is more useful behaviour.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk74UlYACgkQaezQq/BJZRZ7TwCfdlYvGn+kEAMdLLI8FnE7UMf4
YVgAnAv/f/B6XOCMeCf2gf28ZthJ5JV/
=FN5T
-----END PGP SIGNATURE-----
--=-=-=--