1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 459C5431FAE
\r
6 for <notmuch@notmuchmail.org>; Mon, 16 Sep 2013 13:15:45 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 4YLNCdYGZLRZ for <notmuch@notmuchmail.org>;
\r
16 Mon, 16 Sep 2013 13:15:37 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id A5878431FAF
\r
19 for <notmuch@notmuchmail.org>; Mon, 16 Sep 2013 13:15:37 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 1FA801000B2;
\r
22 Mon, 16 Sep 2013 23:15:30 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH] contrib: pick: tidy up pick-format-field
\r
26 In-Reply-To: <1379234477-14089-1-git-send-email-markwalters1009@gmail.com>
\r
27 References: <1379234477-14089-1-git-send-email-markwalters1009@gmail.com>
\r
28 User-Agent: Notmuch/0.16+86~g2d126a3 (http://notmuchmail.org) Emacs/24.3.1
\r
29 (x86_64-unknown-linux-gnu)
\r
30 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
31 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
32 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
33 Date: Mon, 16 Sep 2013 23:15:29 +0300
\r
34 Message-ID: <m2y56wcyla.fsf@guru.guru-group.fi>
\r
36 Content-Type: text/plain
\r
37 X-BeenThere: notmuch@notmuchmail.org
\r
38 X-Mailman-Version: 2.1.13
\r
40 List-Id: "Use and development of the notmuch mail system."
\r
41 <notmuch.notmuchmail.org>
\r
42 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
43 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
44 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
45 List-Post: <mailto:notmuch@notmuchmail.org>
\r
46 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
47 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
49 X-List-Received-Date: Mon, 16 Sep 2013 20:15:45 -0000
\r
51 On Sun, Sep 15 2013, Mark Walters <markwalters1009@gmail.com> wrote:
\r
53 > Previously this function used a temporary variable to store the return
\r
54 > value but we can just use the return value of the cond statement
\r
57 > The only tiny subtlety is that in one case (subject) we need to
\r
58 > slightly reorder the logic to make sure the formatted-field is the
\r
59 > last thing computed.
\r
62 > This follows Tomi's suggestion in id:m2ob7vg24n.fsf@guru.guru-group.fi
\r
68 > and simplifies the code here slightly. This patch applies on top of the
\r
69 > series at id:1378092488-32050-1-git-send-email-markwalters1009@gmail.com
\r
71 > (It also includes one small whitespace fix-up for the face for the tags)
\r
74 > contrib/notmuch-pick/notmuch-pick.el | 49 ++++++++++++++-------------------
\r
75 > 1 files changed, 21 insertions(+), 28 deletions(-)
\r