Return-Path: <tomi.ollila@iki.fi>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 459C5431FAE
	for <notmuch@notmuchmail.org>; Mon, 16 Sep 2013 13:15:45 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 4YLNCdYGZLRZ for <notmuch@notmuchmail.org>;
	Mon, 16 Sep 2013 13:15:37 -0700 (PDT)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
	by olra.theworths.org (Postfix) with ESMTP id A5878431FAF
	for <notmuch@notmuchmail.org>; Mon, 16 Sep 2013 13:15:37 -0700 (PDT)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
	by guru.guru-group.fi (Postfix) with ESMTP id 1FA801000B2;
	Mon, 16 Sep 2013 23:15:30 +0300 (EEST)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] contrib: pick: tidy up pick-format-field
In-Reply-To: <1379234477-14089-1-git-send-email-markwalters1009@gmail.com>
References: <1379234477-14089-1-git-send-email-markwalters1009@gmail.com>
User-Agent: Notmuch/0.16+86~g2d126a3 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Mon, 16 Sep 2013 23:15:29 +0300
Message-ID: <m2y56wcyla.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Sep 2013 20:15:45 -0000

On Sun, Sep 15 2013, Mark Walters <markwalters1009@gmail.com> wrote:

> Previously this function used a temporary variable to store the return
> value but we can just use the return value of the cond statement
> directly.
>
> The only tiny subtlety is that in one case (subject) we need to
> slightly reorder the logic to make sure the formatted-field is the
> last thing computed.
> ---

> This follows Tomi's suggestion in id:m2ob7vg24n.fsf@guru.guru-group.fi

LGTM

Tomi

> and simplifies the code here slightly. This patch applies on top of the
> series at id:1378092488-32050-1-git-send-email-markwalters1009@gmail.com
>
> (It also includes one small whitespace fix-up for the face for the tags)
>
>
>  contrib/notmuch-pick/notmuch-pick.el |   49 ++++++++++++++-------------------
>  1 files changed, 21 insertions(+), 28 deletions(-)
>