1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id 083686DE02B0
\r
6 for <notmuch@notmuchmail.org>; Fri, 10 Jun 2016 04:13:45 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=0.571 tagged_above=-999 required=5 tests=[AWL=-0.081,
\r
12 SPF_NEUTRAL=0.652] autolearn=disabled
\r
13 Received: from arlo.cworth.org ([127.0.0.1])
\r
14 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 4cST341FF9gt for <notmuch@notmuchmail.org>;
\r
16 Fri, 10 Jun 2016 04:13:37 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by arlo.cworth.org (Postfix) with ESMTP id D17716DE0222
\r
19 for <notmuch@notmuchmail.org>; Fri, 10 Jun 2016 04:13:36 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 9BE48100104;
\r
22 Fri, 10 Jun 2016 14:13:26 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH] lib: fix memory leak of field processor objects
\r
26 In-Reply-To: <1465526268-9522-1-git-send-email-david@tethera.net>
\r
27 References: <1465526268-9522-1-git-send-email-david@tethera.net>
\r
28 User-Agent: Notmuch/0.22+32~gd4854c5 (http://notmuchmail.org) Emacs/24.5.1
\r
29 (x86_64-unknown-linux-gnu)
\r
30 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
31 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
32 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
33 Date: Fri, 10 Jun 2016 14:13:26 +0300
\r
34 Message-ID: <m2oa79thyh.fsf@guru.guru-group.fi>
\r
36 Content-Type: text/plain
\r
37 X-BeenThere: notmuch@notmuchmail.org
\r
38 X-Mailman-Version: 2.1.20
\r
40 List-Id: "Use and development of the notmuch mail system."
\r
41 <notmuch.notmuchmail.org>
\r
42 List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
\r
43 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
44 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
45 List-Post: <mailto:notmuch@notmuchmail.org>
\r
46 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
47 List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
49 X-List-Received-Date: Fri, 10 Jun 2016 11:13:45 -0000
\r
51 On Fri, Jun 10 2016, David Bremner <david@tethera.net> wrote:
\r
53 > The field processor objects need to be deallocated explicitly just like
\r
54 > the range processors (or a talloc destructor defined).
\r
56 > lib/database.cc | 7 +++++++
\r
57 > 1 file changed, 7 insertions(+)
\r
59 > diff --git a/lib/database.cc b/lib/database.cc
\r
60 > index 2b2d821..afafe88 100644
\r
61 > --- a/lib/database.cc
\r
62 > +++ b/lib/database.cc
\r
63 > @@ -1107,6 +1107,13 @@ notmuch_database_close (notmuch_database_t *notmuch)
\r
64 > delete notmuch->last_mod_range_processor;
\r
65 > notmuch->last_mod_range_processor = NULL;
\r
67 > +#if HAVE_XAPIAN_FIELD_PROCESSOR
\r
68 > + delete notmuch->date_field_processor;
\r
69 > + notmuch->date_field_processor = NULL;
\r
70 > + delete notmuch->query_field_processor;
\r
71 > + notmuch->query_field_processor = NULL;
\r
75 ... ok, it was this I marked trivial and not the one I wrote in
\r
76 id:m2r3c5ti1c.fsf@guru.guru-group.fi (the same thought about triviality may
\r