From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] lib: fix memory leak of field processor objects
In-Reply-To: <1465526268-9522-1-git-send-email-david@tethera.net>
References: <1465526268-9522-1-git-send-email-david@tethera.net>
User-Agent: Notmuch/0.22+32~gd4854c5 (http://notmuchmail.org) Emacs/24.5.1
 (x86_64-unknown-linux-gnu)
Date: Fri, 10 Jun 2016 14:13:26 +0300
Message-ID: <m2oa79thyh.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Fri, Jun 10 2016, David Bremner <david@tethera.net> wrote:

> The field processor objects need to be deallocated explicitly just like
> the range processors (or a talloc destructor defined).
> ---
>  lib/database.cc | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/lib/database.cc b/lib/database.cc
> index 2b2d821..afafe88 100644
> --- a/lib/database.cc
> +++ b/lib/database.cc
> @@ -1107,6 +1107,13 @@ notmuch_database_close (notmuch_database_t *notmuch)
>      delete notmuch->last_mod_range_processor;
>      notmuch->last_mod_range_processor = NULL;
>  
> +#if HAVE_XAPIAN_FIELD_PROCESSOR
> +    delete notmuch->date_field_processor;
> +    notmuch->date_field_processor = NULL;
> +    delete notmuch->query_field_processor;
> +    notmuch->query_field_processor = NULL;
> +#endif
> +

... ok, it was this I marked trivial and not the one I wrote in
id:m2r3c5ti1c.fsf@guru.guru-group.fi (the same thought about triviality may
apply, though)


>      return status;
>  }
>  
> -- 
> 2.8.1