--- /dev/null
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 4D866429E25\r
+ for <notmuch@notmuchmail.org>; Fri, 3 Jun 2011 13:21:44 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+ tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+ FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 4GzzROLEwXLh for <notmuch@notmuchmail.org>;\r
+ Fri, 3 Jun 2011 13:21:43 -0700 (PDT)\r
+Received: from mail-bw0-f53.google.com (mail-bw0-f53.google.com\r
+ [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id E5B08431FB6\r
+ for <notmuch@notmuchmail.org>; Fri, 3 Jun 2011 13:21:42 -0700 (PDT)\r
+Received: by bwg12 with SMTP id 12so2235026bwg.26\r
+ for <notmuch@notmuchmail.org>; Fri, 03 Jun 2011 13:21:41 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+ h=domainkey-signature:from:to:subject:in-reply-to:references\r
+ :user-agent:date:message-id:mime-version:content-type;\r
+ bh=iF0NXSwJuOa5sdbVHBehW3+jhit6R0dJghVLfkbctwQ=;\r
+ b=P65NDbNFIEejt788NfH1zcEP1ogNULbUE9jg4ibGMPneFRzacS5n6UMrsSAmky6U4T\r
+ dAoXtk3GbvxwLo4P/hdxnjLloye7481KXgFFYRSY+zeeeqiOwp7mKnQDMaVaFwXYBNi1\r
+ ikifO4PXrrvzgYaauFJ5LZA5euF8Rj19UEkck=\r
+DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;\r
+ h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+ :mime-version:content-type;\r
+ b=Oc2X8cOjN32QbQ9i5kwj7gyJ7kASXxxuWJjrhbnZBpYOVjpkhiwe0q22zyA8Kx4VUS\r
+ 47Nkr155cLPrKEj0T6EUcSVKhZFkM9QMynBoqmS0loE5uOKLzWCkX3w6RHdPoV1AuBHw\r
+ /KVW3H7jzv49fs+5T9duSy+Vplc0/Auk+1Mnw=\r
+Received: by 10.204.38.194 with SMTP id c2mr2219135bke.90.1307132501388;\r
+ Fri, 03 Jun 2011 13:21:41 -0700 (PDT)\r
+Received: from localhost ([91.144.186.21])\r
+ by mx.google.com with ESMTPS id k10sm1498019bkq.22.2011.06.03.13.21.39\r
+ (version=TLSv1/SSLv3 cipher=OTHER);\r
+ Fri, 03 Jun 2011 13:21:39 -0700 (PDT)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: Carl Worth <cworth@cworth.org>, Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH 14/25] Fix old style notmuch-fcc-dirs configuration check.\r
+In-Reply-To: <87oc2ellzn.fsf@yoom.home.cworth.org>\r
+References: <1306619520-25730-1-git-send-email-jrollins@finestructure.net>\r
+ <1306619520-25730-2-git-send-email-jrollins@finestructure.net>\r
+ <1306619520-25730-3-git-send-email-jrollins@finestructure.net>\r
+ <1306619520-25730-4-git-send-email-jrollins@finestructure.net>\r
+ <1306619520-25730-5-git-send-email-jrollins@finestructure.net>\r
+ <1306619520-25730-6-git-send-email-jrollins@finestructure.net>\r
+ <1306619520-25730-7-git-send-email-jrollins@finestructure.net>\r
+ <1306619520-25730-8-git-send-email-jrollins@finestructure.net>\r
+ <1306619520-25730-9-git-send-email-jrollins@finestructure.net>\r
+ <1306619520-25730-10-git-send-email-jrollins@finestructure.net>\r
+ <1306619520-25730-11-git-send-email-jrollins@finestructure.net>\r
+ <1306619520-25730-12-git-send-email-jrollins@finestructure.net>\r
+ <1306619520-25730-13-git-send-email-jrollins@finestructure.net>\r
+ <1306619520-25730-14-git-send-email-jrollins@finestructure.net>\r
+ <1306619520-25730-15-git-send-email-jrollins@finestructure.net>\r
+ <874o48yg28.fsf@yoom.home.c worth.org> <87lixkpw16.fsf@gmail.com>\r
+ <87oc2ellzn.fsf@yoom.home.cworth.org>\r
+User-Agent: Notmuch/0.5-208-g109ec1a (http://notmuchmail.org) Emacs/23.3.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sat, 04 Jun 2011 00:22:04 +0400\r
+Message-ID: <87ipsmpswj.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 03 Jun 2011 20:21:44 -0000\r
+\r
+On Fri, 03 Jun 2011 13:05:00 -0700, Carl Worth <cworth@cworth.org> wrote:\r
+Non-text part: multipart/signed\r
+> On Thu, 02 Jun 2011 10:49:57 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
+> > Well, it says that changes are in notmuch 0.5. So "old" and "previous"\r
+> > refer to pre-0.5 (i.e. 0.4) and "new" refers to 0.5.\r
+> \r
+> Sure, but I happen to ahve already forgotten the details of how the\r
+> variable could be configured in 0.4 and in 0.5. More importantly, anyone\r
+> in the future reading the commit log is much more likely not to\r
+> remember.\r
+> \r
+> > Any configuration when `notmuch-fcc-dirs' is a list. That variable has\r
+> > a nice documentation.\r
+> \r
+> Again, I'd like our commit messages to be self-contained. They are much\r
+> more useful if the describe the change being made without assuming to\r
+> much outside knowledge.\r
+> \r
+> > > It would be easier to understand the code if there were a corresponding\r
+> > > test case for it.\r
+> ...\r
+> > I do not think we need a test for this fix. What we need are tests for\r
+> > FCC functionality when notmuch-fcc-dirs is a list.\r
+> \r
+> Yes!\r
+> \r
+> > Old configuration format was changed in 0.5 in an incompatible way.\r
+> > There is a check for the unsupported old-style configuration. But the\r
+> > check is broken and results in an error when running with a valid\r
+> > new-style configuration.\r
+> \r
+> This is actually what I meant by "corresponding test case". If the bug\r
+> here is that a "new-style configuration" doesn't work , (and I still\r
+> don't like that wording---don't say "new style"---explain what it\r
+> actually *is*), then yes, we need a test case showing that bug.\r
+> \r
+> > I am not sure what you expect from the commit message here. IMO it is\r
+> > enough for this small bugfix and those who interested can always refer\r
+> > to documentation for details.\r
+> \r
+> The commit message should provide a self-contained description of the\r
+> change. It should be along the lines of:\r
+> \r
+> When fcc-dirs is set to\r
+> <some-particular-datatype-that-should-work> notmuch was\r
+> incorecctly detecting this as the\r
+> <old-style-that-is-no-longer-supported> and generating an error\r
+> message. Fix the test so that this configuration now works.\r
+> \r
+> Where the <phrases> above should be replaced with actual descriptions,\r
+> not relative pointers to information like "old style" or "new style".\r
+> \r
+> Does that make sense?\r
+> \r
+\r
+"notmuch was incorecctly detecting this as the ..." is not right. It is\r
+a wrong-type-argument lisp error (evaluating (length '(a . b))). How\r
+about:\r
+\r
+ Fix wrong-type-argument lisp error in `notmuch-fcc-header-setup' when\r
+ `notmuch-fcc-dirs' is set to a list. The error was in the\r
+ `notmuch-fcc-dirs' format check which was changed in an incompatible\r
+ way from 0.4 to 0.5.\r
+\r
+Regards,\r
+ Dmitry\r
+\r
+> -Carl\r
+Non-text part: application/pgp-signature\r
projects / notmuch-archives.git / commitdiff