Re: [PATCH 14/25] Fix old style notmuch-fcc-dirs configuration check.

diff --git a/20/28394baa7b6e1e5df25bf5dcb6c6b9ff797bfd b/20/28394baa7b6e1e5df25bf5dcb6c6b9ff797bfd
new file mode 100644 (file)
index 0000000..1d38519
--- /dev/null
+++ b/20/28394baa7b6e1e5df25bf5dcb6c6b9ff797bfd
@@ -0,0 +1,133 @@
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id E270F431FD0\r
+       for <notmuch@notmuchmail.org>; Fri,  3 Jun 2011 13:05:07 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.01\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.01 tagged_above=-999 required=5\r
+       tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id hKUkiUW3VL9T for <notmuch@notmuchmail.org>;\r
+       Fri,  3 Jun 2011 13:05:07 -0700 (PDT)\r
+Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1F619431FB6\r
+       for <notmuch@notmuchmail.org>; Fri,  3 Jun 2011 13:05:06 -0700 (PDT)\r
+Received: from yoom.home.cworth.org (localhost [127.0.0.1])\r
+       by arlo.cworth.org (Postfix) with ESMTP id 65F8B29A604;\r
+       Fri,  3 Jun 2011 13:05:01 -0700 (PDT)\r
+Received: by yoom.home.cworth.org (Postfix, from userid 1000)\r
+       id 1F90E25417E; Fri,  3 Jun 2011 13:05:01 -0700 (PDT)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,\r
+       Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH 14/25] Fix old style notmuch-fcc-dirs configuration check.\r
+In-Reply-To: <87lixkpw16.fsf@gmail.com>\r
+References: <1306619520-25730-1-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-2-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-3-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-4-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-5-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-6-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-7-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-8-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-9-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-10-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-11-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-12-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-13-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-14-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-15-git-send-email-jrollins@finestructure.net>\r
+       <874o48yg28.fsf@yoom.home.c worth.org> <87lixkpw16.fsf@gmail.com>\r
+User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1\r
+       (i486-pc-linux-gnu)\r
+Date: Fri, 03 Jun 2011 13:05:00 -0700\r
+Message-ID: <87oc2ellzn.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 03 Jun 2011 20:05:08 -0000\r
+\r
+--=-=-=\r
+\r
+On Thu, 02 Jun 2011 10:49:57 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
+> Well, it says that changes are in notmuch 0.5.  So "old" and "previous"\r
+> refer to pre-0.5 (i.e. 0.4) and "new" refers to 0.5.\r
+\r
+Sure, but I happen to ahve already forgotten the details of how the\r
+variable could be configured in 0.4 and in 0.5. More importantly, anyone\r
+in the future reading the commit log is much more likely not to\r
+remember.\r
+\r
+> Any configuration when `notmuch-fcc-dirs' is a list.  That variable has\r
+> a nice documentation.\r
+\r
+Again, I'd like our commit messages to be self-contained. They are much\r
+more useful if the describe the change being made without assuming to\r
+much outside knowledge.\r
+\r
+> > It would be easier to understand the code if there were a corresponding\r
+> > test case for it.\r
+...\r
+> I do not think we need a test for this fix.  What we need are tests for\r
+> FCC functionality when notmuch-fcc-dirs is a list.\r
+\r
+Yes!\r
+\r
+> Old configuration format was changed in 0.5 in an incompatible way.\r
+> There is a check for the unsupported old-style configuration.  But the\r
+> check is broken and results in an error when running with a valid\r
+> new-style configuration.\r
+\r
+This is actually what I meant by "corresponding test case". If the bug\r
+here is that a "new-style configuration" doesn't work , (and I still\r
+don't like that wording---don't say "new style"---explain what it\r
+actually *is*), then yes, we need a test case showing that bug.\r
+\r
+> I am not sure what you expect from the commit message here.  IMO it is\r
+> enough for this small bugfix and those who interested can always refer\r
+> to documentation for details.\r
+\r
+The commit message should provide a self-contained description of the\r
+change. It should be along the lines of:\r
+\r
+       When fcc-dirs is set to\r
+       <some-particular-datatype-that-should-work> notmuch was\r
+       incorecctly detecting this as the\r
+       <old-style-that-is-no-longer-supported> and generating an error\r
+       message. Fix the test so that this configuration now works.\r
+\r
+Where the <phrases> above should be replaced with actual descriptions,\r
+not relative pointers to information like "old style" or "new style".\r
+\r
+Does that make sense?\r
+\r
+-Carl\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iEYEARECAAYFAk3pPmwACgkQ6JDdNq8qSWggNwCfUZIISt65QlMf1PZ3c+x22s6/\r
+LlMAn1r3/eY8b1ov4Z4rmnkbjMG8pA7Q\r
+=/kso\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r