Re: [notmuch] [PATCH 1/2] lib/message: Add function to get maildir flags.

diff --git a/39/7ef66fe5ba706b3304750d1d861e0657f50994 b/39/7ef66fe5ba706b3304750d1d861e0657f50994
new file mode 100644 (file)
index 0000000..a46d394
--- /dev/null
+++ b/39/7ef66fe5ba706b3304750d1d861e0657f50994
@@ -0,0 +1,85 @@
+Return-Path: <stefan@datenfreihafen.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id B2DE3431FBC\r
+       for <notmuch@notmuchmail.org>; Sun, 22 Nov 2009 11:52:54 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id TrLH7uZhkvFU for <notmuch@notmuchmail.org>;\r
+       Sun, 22 Nov 2009 11:52:53 -0800 (PST)\r
+Received: from sirius.lasnet.de (sirius.lasnet.de [78.47.116.19])\r
+       by olra.theworths.org (Postfix) with ESMTP id 7024B431FAE\r
+       for <notmuch@notmuchmail.org>; Sun, 22 Nov 2009 11:52:53 -0800 (PST)\r
+Received: from p5b0353d3.dip.t-dialin.net ([91.3.83.211] helo=excalibur)\r
+       by sirius.lasnet.de with esmtpsa \r
+       (Cipher TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63 #1)\r
+       id 1NCIUJ-0002QO-OM by authid <stefan@sostec.de> with cram_md5;\r
+       Sun, 22 Nov 2009 20:52:50 +0100\r
+Received: from stefan by excalibur with local (Exim 4.69)\r
+       (envelope-from <stefan@excalibur.local>)\r
+       id 1NCIUI-0003ON-Sr; Sun, 22 Nov 2009 20:52:46 +0100\r
+Date: Sun, 22 Nov 2009 20:52:46 +0100\r
+From: Stefan Schmidt <stefan@datenfreihafen.org>\r
+To: Michiel Buddingh' <michiel@michielbuddingh.net>\r
+Message-ID: <20091122195246.GC5735@excalibur.local>\r
+References: <yes> <1258848661-4660-1-git-send-email-stefan@datenfreihafen.org>\r
+       <yunvdh3pfm9.fsf@aiko.keithp.com>\r
+       <20091122183338.GB5735@excalibur.local>\r
+       <4b09891e.YhJ/aJZOBwneOaFr%michiel@michielbuddingh.net>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <4b09891e.YhJ/aJZOBwneOaFr%michiel@michielbuddingh.net>\r
+X-Mailer: Mutt http://www.mutt.org/\r
+X-KeyID: 0xDDF51665\r
+X-Website: http://www.datenfreihafen.org/\r
+User-Agent: Mutt/1.5.20 (2009-06-14)\r
+Cc: notmuch@notmuchmail.org\r
+Subject: Re: [notmuch] [PATCH 1/2] lib/message: Add function to get maildir\r
+ flags.\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.12\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 22 Nov 2009 19:52:54 -0000\r
+\r
+Hello.\r
+\r
+On Sun, 2009-11-22 at 19:55, Michiel Buddingh' wrote:\r
+> Stefan Schmidt <stefan@datenfreihafen.org> wrote:\r
+> > > This function should interpret the flags that it finds and return a\r
+> > > suitable set of notmuch tags. I'd suggest that 'unread' messages get\r
+> > > both 'unread' and 'inbox' tags, as Maildir doesn't distinguish between\r
+> > > 'don't show this to be by default again please' and 'I've read this\r
+> > > message'. It seems best to hide the maildir-specific details inside the\r
+> > > library instead of exposing them.\r
+> >\r
+> > Thanks for the review. On a second thought the interface was really a bit ugly.\r
+> > :)\r
+> >\r
+> > I'm just back to my box and going through the outstanding mails shows me that\r
+> > Michiel Buddingh has a more complete patch on the\r
+> > convert-maildir-flags-into-tags issue which Carl has tagged for review. Will\r
+> > wait what comes out of it and if anything is left for me to. :)\r
+> \r
+> Apologies.  In my haste to cover up my appalling and incorrect first patch, I\r
+> neglected to review the archives to see if someone had already done this. Sorry\r
+> for stealing your thunder.\r
+\r
+No need to be sorry. I'm interestecd in having this itch scratched, but don't\r
+care who is doing it. :)\r
+\r
+Just go ahead and get it in after Carl's review.\r
+\r
+regards\r
+Stefan Schmidt\r