Re: [notmuch] [PATCH 1/2] lib/message: Add function to get maildir flags.

diff --git a/4d/7b6e0528117ec3d09acf51a726ce5f5de4a0e3 b/4d/7b6e0528117ec3d09acf51a726ce5f5de4a0e3
new file mode 100644 (file)
index 0000000..7f753e9
--- /dev/null
+++ b/4d/7b6e0528117ec3d09acf51a726ce5f5de4a0e3
@@ -0,0 +1,70 @@
+Return-Path: <michiel@michielbuddingh.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id B580E431FBC\r
+       for <notmuch@notmuchmail.org>; Sun, 22 Nov 2009 10:55:27 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id JHZeV0d6+Q8a for <notmuch@notmuchmail.org>;\r
+       Sun, 22 Nov 2009 10:55:26 -0800 (PST)\r
+Received: from aegir.org.uk (aegir.org.uk [87.238.170.13])\r
+       by olra.theworths.org (Postfix) with ESMTP id C6AAC431FAE\r
+       for <notmuch@notmuchmail.org>; Sun, 22 Nov 2009 10:55:26 -0800 (PST)\r
+Received: from localhost.localdomain (109-9-ftth.onsnetstudenten.nl\r
+       [145.120.9.109])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by aegir.org.uk (Postfix) with ESMTPSA id 48CE72E02A;\r
+       Sun, 22 Nov 2009 19:55:26 +0100 (CET)\r
+Date: Sun, 22 Nov 2009 19:55:26 +0100\r
+From: Michiel Buddingh' <michiel@michielbuddingh.net>\r
+To: notmuch@notmuchmail.org, stefan@datenfreihafen.org,\r
+ keithp@keithp.com\r
+Message-ID: <4b09891e.YhJ/aJZOBwneOaFr%michiel@michielbuddingh.net>\r
+References: <yes> <1258848661-4660-1-git-send-email-stefan@datenfreihafen.org>\r
+       <yunvdh3pfm9.fsf@aiko.keithp.com>\r
+       <20091122183338.GB5735@excalibur.local>\r
+In-Reply-To: <20091122183338.GB5735@excalibur.local>\r
+User-Agent: Heirloom mailx 12.4 7/29/08\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Transfer-Encoding: 7bit\r
+Subject: Re: [notmuch] [PATCH 1/2] lib/message: Add function to get maildir\r
+ flags.\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.12\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 22 Nov 2009 18:55:27 -0000\r
+\r
+Stefan Schmidt <stefan@datenfreihafen.org> wrote:\r
+> > This function should interpret the flags that it finds and return a\r
+> > suitable set of notmuch tags. I'd suggest that 'unread' messages get\r
+> > both 'unread' and 'inbox' tags, as Maildir doesn't distinguish between\r
+> > 'don't show this to be by default again please' and 'I've read this\r
+> > message'. It seems best to hide the maildir-specific details inside the\r
+> > library instead of exposing them.\r
+>\r
+> Thanks for the review. On a second thought the interface was really a bit ugly.\r
+> :)\r
+>\r
+> I'm just back to my box and going through the outstanding mails shows me that\r
+> Michiel Buddingh has a more complete patch on the\r
+> convert-maildir-flags-into-tags issue which Carl has tagged for review. Will\r
+> wait what comes out of it and if anything is left for me to. :)\r
+\r
+Apologies.  In my haste to cover up my appalling and incorrect first patch, I\r
+neglected to review the archives to see if someone had already done this. Sorry\r
+for stealing your thunder.\r
+\r
+Michiel\r