Re: [PATCH 2/5] go: Update for changes to notmuch_database_get_directory

diff --git a/cd/d93f362970e833085bb4573b97127553e109ad b/cd/d93f362970e833085bb4573b97127553e109ad
new file mode 100644 (file)
index 0000000..b2857aa
--- /dev/null
+++ b/cd/d93f362970e833085bb4573b97127553e109ad
@@ -0,0 +1,84 @@
+Return-Path: <teythoon@jade-hamburg.de>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id D7B46431FB6\r
+       for <notmuch@notmuchmail.org>; Sun, 13 May 2012 14:52:55 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Xrgk+Y+YazXb for <notmuch@notmuchmail.org>;\r
+       Sun, 13 May 2012 14:52:54 -0700 (PDT)\r
+Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68])\r
+       (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id DEAB3431FAE\r
+       for <notmuch@notmuchmail.org>; Sun, 13 May 2012 14:52:53 -0700 (PDT)\r
+Received: from mail.jade-hamburg.de (mail.jade-hamburg.de [85.183.11.228])\r
+       (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by mail.cryptobitch.de (Postfix) with ESMTPSA id DA725587D9F\r
+       for <notmuch@notmuchmail.org>; Sun, 13 May 2012 23:52:51 +0200 (CEST)\r
+Received: by mail.jade-hamburg.de (Postfix, from userid 401)\r
+       id 5AFBEDF2A3; Sun, 13 May 2012 23:52:51 +0200 (CEST)\r
+Received: from thinkbox.jade-hamburg.de (thinkbox.jadE-Hamburg.de\r
+ [10.1.1.153]) (using TLSv1 with cipher AES256-SHA (256/256 bits))     (No client\r
+ certificate requested) (Authenticated sender: teythoon)       by\r
+ mail.jade-hamburg.de (Postfix) with ESMTPSA id 608E9DF2A0;    Sun, 13 May 2012\r
+ 23:52:39 +0200 (CEST)\r
+Received: from teythoon by thinkbox.jade-hamburg.de with local (Exim 4.77)\r
+       (envelope-from <teythoon@thinkbox.jade-hamburg.de>)\r
+       id 1STghT-0004Ff-7V; Sun, 13 May 2012 23:51:35 +0200\r
+Content-Type: text/plain; charset="utf-8"\r
+MIME-Version: 1.0\r
+Content-Transfer-Encoding: quoted-printable\r
+To: Austin Clements <amdragon@MIT.EDU>,  notmuch@notmuchmail.org\r
+From: Justus Winter <4winter@informatik.uni-hamburg.de>\r
+In-Reply-To: <1336939029-13969-3-git-send-email-amdragon@mit.edu>\r
+References: <1336939029-13969-1-git-send-email-amdragon@mit.edu>\r
+       <1336939029-13969-3-git-send-email-amdragon@mit.edu>\r
+Message-ID: <20120513215135.15106.40581@thinkbox.jade-hamburg.de>\r
+User-Agent: alot/0.3+\r
+Subject: Re: [PATCH 2/5] go: Update for changes to\r
+       notmuch_database_get_directory\r
+Date: Sun, 13 May 2012 23:51:35 +0200\r
+Cc: tomi.ollila@iki.fi\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 13 May 2012 21:52:56 -0000\r
+\r
+Hi Austin,\r
+\r
+thanks for taking care of this.\r
+\r
+Quoting Austin Clements (2012-05-13 21:57:06)\r
+> ---\r
+>  bindings/go/src/notmuch/notmuch.go  |   13 +++++++------\r
+>  bindings/python/notmuch/database.py |    4 ++--\r
+\r
+A change to the python bindings slipped into this one.\r
+\r
+Other than that this looks good.\r
+\r
+I just saw that I marked another function as problematic,\r
+notmuch_database_find_message_by_filename ends up calling\r
+_notmuch_directory_create that aborts if the database is not\r
+writable. But this might have to wait and might not even requira an\r
+api change.\r
+\r
+Justus\r